Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 35374
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: Nobody in particular
Requestors: jquelin [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.81
Fixed in: (no value)



Subject: external_license_file not set if license set in META.yml
Download (untitled) / with headers
text/plain 829b
here are some excerpts of Module::CPANTS::Kwalitee::License::analyse # check META.yml my $yaml=$me->d->{meta_yml}; if ($yaml) { if ($yaml->{license} and $yaml->{license} ne 'unknown') { $me->d->{license} = $yaml->{license}; return; } } ==> note that you return if yaml specifies a license. analyse() then continues (if no yaml, or no license in yaml) to check if there's a LICEN[CS]E file. and you will note in particular line 32 where you set external_license_file: $me->d->{external_license_file}=$file; this line is never reached in some cases (yaml sets license), although you're using this key line 74 for a kwalitee metric: code=>sub { shift->{external_license_file} ? 1 : 0 } this is wrong. you should always test external license file...
Download (untitled) / with headers
text/plain 1022b
This issue was fixed with Module::CPANTS::Analyse 0.82, without closing this ticket. Thanks. On Thu Apr 24 23:53:41 2008, JQUELIN wrote: Show quoted text
> here are some excerpts of Module::CPANTS::Kwalitee::License::analyse > > # check META.yml > my $yaml=$me->d->{meta_yml}; > if ($yaml) { > if ($yaml->{license} and $yaml->{license} ne 'unknown') { > $me->d->{license} = $yaml->{license}; > return; > } > } > > ==> note that you return if yaml specifies a license. > > analyse() then continues (if no yaml, or no license in yaml) to check if > there's a LICEN[CS]E file. and you will note in particular line 32 where > you set external_license_file: > > $me->d->{external_license_file}=$file; > > this line is never reached in some cases (yaml sets license), although > you're using this key line 74 for a kwalitee metric: > > code=>sub { shift->{external_license_file} ? 1 : 0 } > > > this is wrong. you should always test external license file...


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.