Skip Menu |
 

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 35257
Status: resolved
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors: TIMBRODY [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.66
Fixed in: (no value)



Subject: unbindNode will attempt to unbind DOCUMENT and DOC_FRAGMENT
Download (untitled) / with headers
text/plain 764b
Found by code inspection although doing unbindNode on a DOCUMENT object doesn't seem to cause problems. In LibXML.xs: void unbindNode( self ) xmlNodePtr self ALIAS: XML::LibXML::Node::unlink = 1 XML::LibXML::Node::unlinkNode = 2 PREINIT: ProxyNodePtr docfrag = NULL; CODE: !!! This is logically TRUE regardless of self->type !!! if ( self->type != XML_DOCUMENT_NODE || self->type != XML_DOCUMENT_FRAG_NODE ) { !!! xmlUnlinkNode( self ); if ( self->type != XML_ATTRIBUTE_NODE ) { docfrag = PmmNewFragment( self->doc ); xmlAddChild( PmmNODE(docfrag), self ); } PmmFixOwner( PmmPROXYNODE(self), docfrag ); }
Thanks, fixed in the SVN. -- Petr


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.