Skip Menu |
 

This queue is for tickets about the URI CPAN distribution.

Report information
The Basics
Id: 35156
Status: resolved
Priority: 0/
Queue: URI

People
Owner: Nobody in particular
Requestors: ishigaki [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: URI::Heuristic doesn't work properly when generic country code is specified
Download (untitled) / with headers
text/plain 583b
Hi. Though its negative fallback test happens to pass, one of the guessed hostname by uf_uristr("perl/camel.gif") is "www.$host.bv." (which should be "www.perl.bv.") when $URI::Heuristic::MY_COUNTRY is set to "bv". Attached patch should fix this. By the way, funky DNS may sometimes return some static ip address even when a host does not exist (to serve advertisement et al). So, sadly the test mentioned above may fail, due not to the module, but to the DNS. I don't think the test should take it into consideration, but anyway, I'd like to report it for your information.
Subject: URI-1.36.patch
Download URI-1.36.patch
text/x-diff 509b
diff -ur URI-1.36/URI/Heuristic.pm URI-1.36-patched/URI/Heuristic.pm --- URI-1.36/URI/Heuristic.pm 2008-04-03 06:24:00.000000000 +0900 +++ URI-1.36-patched/URI/Heuristic.pm 2008-04-18 00:45:13.849250000 +0900 @@ -172,7 +172,7 @@ push(@guess, map { s/\bACME\b/$host/; $_ } @special); } else { - push(@guess, 'www.$host.' . MY_COUNTRY()); + push(@guess, "www.$host." . MY_COUNTRY()); } } push(@guess, map "www.$host.$_",
Applied. Thanks!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.