Skip Menu |
 

This queue is for tickets about the WWW-Google-SiteMap CPAN distribution.

Report information
The Basics
Id: 34925
Status: resolved
Priority: 0/
Queue: WWW-Google-SiteMap

People
Owner: Nobody in particular
Requestors: russelj9 [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.09
Fixed in: (no value)



Subject: Negative timezone offsets aren't working
Download (untitled) / with headers
text/plain 765b
Okay I hope I'm posting this bug in the right place (this is my first time reporting a bug). I'm using WWW::Google::SiteMap in my program and it's not handling negative time zone offsets when I give it a last modification date with one. It's a little hard to explain so I included an example program file that displays this bug. But anyways inspecting it on my own. Looking in the file WWW::Google::SiteMap::Url.pm, The sub routine lastmod() can be changed and then it works for me. Basically on line 164 of the file where it has the code " } elsif(/^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\+\d\d:\d\d$/) {" I changed it to " } elsif(/^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d\+|-\d\d:\d\d$/) {" and then it works for me. I'm running perl, v5.8.8 on mac os x 10.5.2
Subject: timezone_test.pl
Download timezone_test.pl
text/x-perl 343b
#!/usr/bin/env perl -w use strict; use warnings; use 5.8.1; use WWW::Google::SiteMap; my $map = WWW::Google::SiteMap->new(file => 'sitemap.gz'); $map->add(WWW::Google::SiteMap::URL->new( loc => 'http://www.google.com/', lastmod => '2008-03-12T12:59:00-07:00', changefreq => 'daily', priority => 1.0, ));
Download (untitled) / with headers
text/plain 213b
JASONK are you still alive? If you are not willing/able to fix these EASY bugs, I will be happy to fix them and upload a new release. Would you be willing to make me co-maintainer on CPAN? TIA - - MTHURN
Download (untitled) / with headers
text/plain 209b
WWW::Google::SiteMap is being superceded by Search::Sitemap now that search engines other than Google are supporting it. This bug has been fixed in Search::Sitemap as of version 2.02. -- www.jasonkohles.com


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.