Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Verilog-Perl CPAN distribution.

Report information
The Basics
Id: 34429
Status: resolved
Priority: 0/
Queue: Verilog-Perl

People
Owner: Nobody in particular
Requestors: admin [...] matveyenko.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: macro with systemVerilog lexical delimiter fails if white spaces present in macro calling
Date: Tue, 25 Mar 2008 14:30:41 -0700 (PDT)
To: bug-Verilog-Perl [...] rt.cpan.org
From: Vladimir Matveyenko <admin [...] matveyenko.com>
Download (untitled) / with headers
text/plain 1.5k
Verilog-Perl-3.012 perl, v5.8.8 built for cygwin-thread-multi-64int CYGWIN_NT-5.1 ecwm0clloan2 1.5.25(0.156/4/2) 2008-03-05 19:27 i686 Cygwin I'm reporting an issue with macro expansion. It appears that preprocessor capturing white spaces from the macro calling parameters and using them in actual macro text. This causes problems if SystemVerilog `` lexical delimiter is used in the macro. Here is an example of harmless expansion: // macro defined `define add(a,b) (a+b) // macro called like this: `add(x, y) // expansion produces (x+ y) // Here is macro defined with SystemVerilog delimiter // --- start of source verilog --- `define ADD_UP(a,c) \ wire tmp_``a = a; \ wire tmp_``c = tmp_``a + 1; \ assign c = tmp_``c ; module test1 ( input wire d1, output wire o1, o2 ); `ADD_UP(d1,o1) // expansion is OK `ADD_UP(d1, o2) // expansion is bad endmodule // --- end of source verilog --- // --- start of post-processed verilog --- `line 1 "junk1.v" 1 module test1 ( input wire d1, output wire o1, o2 ); wire tmp_d1 = d1; wire tmp_o1 = tmp_d1 + 1; assign o1 = tmp_o1 ; // PASS MACRO wire tmp_d1 = d1; wire tmp_ o2 = tmp_d1 + 1; assign o2 = tmp_ o2 ; // FAIL MACRO endmodule // --- end of post-processed verilog --- Steps to duplicate the problem: 1) vppp test1.v > test1.vppp 2) vhier test1.vppp %Error: junk1.v:9: syntax error, unexpected IDENTIFIER, expecting ',' or ';' %Error: junk1.v:9: syntax error, unexpected IDENTIFIER, expecting ',' or ';' Thank you
Download (untitled) / with headers
text/plain 398b
Thanks for the good example. This is fixed in the next upcomming release, perhaps Monday. The patch is large, let me know if you want it earlier. There were other spacing bugs and macro-in-macro bugs that I found related to this too. I'd also note that spaces AFTER the parameter do not seem to get compressed in other simulators, IE `call(a,b) === `call( a,b) but `call(a,b) !== `call(a ,b)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.