Skip Menu |
 

This queue is for tickets about the Text-WikiFormat CPAN distribution.

Report information
The Basics
Id: 34402
Status: new
Priority: 0/
Queue: Text-WikiFormat

People
Owner: Nobody in particular
Requestors: cpan [...] desert-island.me.uk
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.79
Fixed in: (no value)



Download (untitled) / with headers
text/plain 436b
The regex in format_line for finding (I assume) CappedLinks is too vague, and also finds links which have already been formatted by the call to "find_extended_links" in the line above it. Patch includes a test which demonstrates what happens if find_extended_links fixes up a link which just happens to end up looking partly like a Capped_Link. The regex should probably avoid anything that looks remotely like an absolute url.
Subject: existing_link.patch
Download existing_link.patch
text/x-diff 893b
Only in ./: blib Only in ./: existing_link.patch Only in ./: Makefile Only in ./: pm_to_blib diff -u -r /usr/src/perl/cpanplus/5.8.8/build/Text-WikiFormat-0.79/t/explicit.t ./t/explicit.t --- /usr/src/perl/cpanplus/5.8.8/build/Text-WikiFormat-0.79/t/explicit.t 2007-06-29 02:48:10.000000000 +0100 +++ ./t/explicit.t 2008-03-24 15:24:27.000000000 +0000 @@ -3,7 +3,7 @@ use strict; use warnings; -use Test::More tests => 4; +use Test::More tests => 5; use Text::WikiFormat; my $wikitext =<<WIKI; @@ -12,6 +12,7 @@ [[Usemod extended link]] +This is an <a href="wiki.pl?Extended_Link">Extended Link</a>. WIKI @@ -39,3 +40,7 @@ like( $htmltext, qr!Usemod extended link</a>[^\]]!m, '...and new delimiters recognised' ); + +like($htmltext, qr!This is an <a href="wiki.pl?Extended_Link">Extended Link</a>.!m, + "... doesn't break existing links"); + Only in ./t: explicit.t~


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.