Skip Menu |
 

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 34364
Status: resolved
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: ZAhmad [...] parusinteractive.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: "Slava Zakovyrya" <SZakovyrya [...] parusinteractive.com>, "Peter Fitzgibbons" <pfitzgibbons [...] parusinteractive.com>
Subject: DBIx::Class::Storage::DBI::_connect() bug
Date: Sun, 23 Mar 2008 05:12:28 -0500
To: <bug-DBIx-Class [...] rt.cpan.org>
From: "Zishan Ahmad" <ZAhmad [...] parusinteractive.com>
Download (untitled) / with headers
text/plain 2.2k
I would have submitted the bug officially, but I'm too lazy right now to register with Bitcard :-) The current code in DBIx::Class::Storage::DBI::_connect() does not suppress DBI::connect() error (i.e. bad credentials) output properly. I see the error printed twice: DBI connect('server=xxxxxxxx','xxxxxx',...) failed: Server message number=4002 severity=14 state=1 line=0 server=xxxxxxxxx text=Login failed. OpenClient message: LAYER = (4) ORIGIN = (1) SEVERITY = (4) NUMBER = (44) Server xxxxxxxx, database Message String: ct_connect(): protocol specific layer: external error: The attempt to connect to the server failed. at ../lib/DBIx/Class/Storage/DBI.pm line 826 DBIx::Class::ResultSet::find(): DBI Connection failed: Server message number=4002 severity=14 state=1 line=0 server=xxxxxxxxx text=Login failed. OpenClient message: LAYER = (4) ORIGIN = (1) SEVERITY = (4) NUMBER = (44) Server xxxxxxxx, database Message String: ct_connect(): protocol specific layer: external error: The attempt to connect to the server failed. This block in sub _connect eval { if(ref $info[0] eq 'CODE') { $dbh = &{$info[0]} } else { $dbh = DBI->connect(@info); } if($dbh && !$self->unsafe) { my $weak_self = $self; weaken($weak_self); $dbh->{HandleError} = sub { $weak_self->throw_exception("DBI Exception: $_[0]") }; $dbh->{ShowErrorStatement} = 1; $dbh->{RaiseError} = 1; $dbh->{PrintError} = 0; } }; Should probably be more like: eval { if(ref $info[0] eq 'CODE') { $dbh = &{$info[0]} } else { if( !$self->unsafe ) { my $weak_self = $self; weaken($weak_self); $info[3]->{HandleError} = sub { $weak_self->throw_exception("DBI Exception: $_[0]") }; $info[3]->{ShowErrorStatement} = 1; $info[3]->{RaiseError} = 1; $info[3]->{PrintError} = 0; } $dbh = DBI->connect(@info); } }; I think it may even be preferable to move that block of code ( if( !$self->unsafe) { } ) to connect_info() to properly populate _connect_info and _dbi_connect_info. Regards. Zishan Ahmad Lead Engineer Parus Interactive Office: 847.919.7032
Download (untitled) / with headers
text/html 12.8k

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 418b
On Sun Mar 23 06:13:06 2008, ZAhmad@parusinteractive.com wrote: Show quoted text
> I would have submitted the bug officially, but I'm too lazy right now to > register with Bitcard :-)-
That's ok, I'm closing it anyway. Please start a discussion about this on the mailing list; we only use rt.cpan for test case + patch reporting, more open ended stuff happens on the list so all 30+ contributors can chip in if they have a good idea.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.