Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the PDF-Table CPAN distribution.

Report information
The Basics
Id: 34017
Status: resolved
Priority: 0/
Queue: PDF-Table

People
Owner: jbazik [...] cpan.org
Requestors: Petri.Kaurinkoski [...] iki.fi
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: PDF::Table::table enters a never ending loop
Date: Wed, 12 Mar 2008 12:34:12 +0200
To: bug-PDF-Table [...] rt.cpan.org
From: Petri Kaurinkoski <Petri.Kaurinkoski [...] iki.fi>
Download (untitled) / with headers
text/plain 1023b
Dear Sirs, I have been working with a perl-program using PDF::Table. I encountered a problem with the table-subroutine entering a never ending loop at the point where long words are split to shorter ones. I looked at the code, and discovered the problem in the exit condition for the loop. I fixed the problem by replacing the whole loop-structure with one global replace-regexp statement. I ask you to consider including my patch (attached) to the PDF::Table v. 0.9.3. I think the new implemetation is even more efficient than the original one as there is no explicit loop in the code. also, I added statement modifier testing whether the desired maximum word length is greater than 0 While tracking down the bug, I discovered that the problem was caused by non-empty $2 at the point where PDF::Table::table was called. A workaround was to do a dummy match $_ =~ m/./; just before the call and thus reset $2. Best regards, Petri Kaurinkoski -- Petri Kaurinkoski <Petri.Kaurinkoski@iki.fi>

Message body is not shown because sender requested not to inline it.

Download (untitled) / with headers
text/plain 161b
Thanks for the contribution and sorry for the delay. Your patch will be included in the upcoming version 1.0 release with re factored code and some new features.
From: avsmith [...] gmail.com
Download (untitled) / with headers
text/plain 312b
On Thu Jun 12 15:37:47 2008, OMEGA wrote: Show quoted text
> Thanks for the contribution and sorry for the delay. Your patch will be > included in the upcoming version 1.0 release with re factored code and > some new features.
I've had trouble with this same bug. It would be good to roll this into the code available at CPAN.
Thanks for reporting this. It's fixed in 0.9.4, just uploaded to cpan. John
Subject: Re: [rt.cpan.org #34017] Resolved: PDF::Table::table enters a never ending loop
Date: Tue, 18 Oct 2011 09:42:24 +0300
To: bug-PDF-Table [...] rt.cpan.org
From: Petri Kaurinkoski <Petri.Kaurinkoski [...] iki.fi>
Download (untitled) / with headers
text/plain 481b
Hi, I just looked at the most recent (0.9.4) release, and I can see my fix in there but it is commented out. Is that intentional? Best regards, Petri Kaurinkoski On Mon, 2011-10-17 at 23:45 -0400, John Bazik via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=34017 > > > According to our records, your request has been resolved. If you have any > further questions or concerns, please respond to this message.
-- Petri Kaurinkoski <Petri.Kaurinkoski@iki.fi>
Download (untitled) / with headers
text/plain 326b
On Tue Oct 18 02:42:02 2011, Petri.Kaurinkoski@iki.fi wrote: Show quoted text
> I just looked at the most recent (0.9.4) release, and I can see my fix > in there but it is commented out. Is that intentional?
Oops - no, my mistake. Testing for an infinite loop works just fine with or without the replacement code. I'll fix it tonight. John
Download (untitled) / with headers
text/plain 124b
Just uploaded 0.9.5 with your fix uncommented. Added a test to ensure it stays there, too. Thanks for catching that. John


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.