Skip Menu |
 

This queue is for tickets about the Readonly-XS CPAN distribution.

Report information
The Basics
Id: 33711
Status: open
Priority: 0/
Queue: Readonly-XS

People
Owner: Nobody in particular
Requestors: dillman [...] ria.buffalo.edu
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: test.t failing in perl 5.10
Date: Fri, 29 Feb 2008 13:01:28 -0500
To: bug-Readonly-XS [...] rt.cpan.org
From: dillman [...] ria.buffalo.edu
In perl 5.10 'use warnings' no longer loads Carp.
Adding 'use Carp' to test.t allows the test script to work.


Thomas J. Dillman
Research Institute on Addictions
1021 Main Street, Buffalo, NY  14203
I have a patch for that on CPAN: ANDK/patches/Readonly-XS-1.04-ANDK-01.patch.gz
Download (untitled) / with headers
text/plain 559b
Hi Eric, Could you please apply Andreas' patch and cut a new release? This will get Readonly::XS working again on 5.10.0. --- XS.pm 2005-12-06 07:04:00.000000000 +0100 +++ XS.pm 2007-11-18 23:00:29.000000000 +0100 @@ -33,7 +33,7 @@ BEGIN if ($MAGIC_COOKIE ne "Do NOT use or require Readonly::XS unless you're me.") { require Carp; - Carp::croak "Readonly::XS is not a standalone module. You should not use it directly."; + Carp::croak("Readonly::XS is not a standalone module. You should not use it directly."); } }
Download (untitled) / with headers
text/plain 800b
On Sat Oct 18 16:11:52 2008, MSCHWERN wrote: Show quoted text
> Hi Eric, > Could you please apply Andreas' patch and cut a new release? This will > get Readonly::XS working again on 5.10.0. > > --- XS.pm 2005-12-06 07:04:00.000000000 +0100 > +++ XS.pm 2007-11-18 23:00:29.000000000 +0100 > @@ -33,7 +33,7 @@ BEGIN > if ($MAGIC_COOKIE ne "Do NOT use or require Readonly::XS unless > you're me.") > { > require Carp; > - Carp::croak "Readonly::XS is not a standalone module. You > should not use it directly."; > + Carp::croak("Readonly::XS is not a standalone module. You > should not use it directly."); > } > } >
I just deduced the same fix myself on my 5.10 and it does indeed fix the problem. Came here to find the bug and patch already in rt. Pinging as a reminder. :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.