Skip Menu |
 

This queue is for tickets about the POE-Component-IRC CPAN distribution.

Report information
The Basics
Id: 33472
Status: resolved
Worked: 16 min
Priority: 0/
Queue: POE-Component-IRC

People
Owner: hinrik.sig [...] gmail.com
Requestors: martin.ferrari [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: PoCo::IRC should trim long lines
Date: Wed, 20 Feb 2008 16:10:44 -0200
To: bug-POE-Component-IRC [...] rt.cpan.org
From: "Martín Ferrari" <martin.ferrari [...] gmail.com>
Download (untitled) / with headers
text/plain 508b
Hi, Today I discovered that a commit notification bot I wrote with PoCo::IRC wes getting kicked out of the server with a "Request too long" message. Inspection revealed that the PRIVMSG it sent to the channel was causing the kick because the raw command was longer than 512 bytes, including \r\n. It seems that my private irc server is one of the few to enforce the limit, but that's what the rfc says, so it'd be nice if your module did check it. Thanks for the nice and useful code! -- Martín Ferrari
Download (untitled) / with headers
text/plain 182b
Hi, Thanks for the ticket. POE::Component::IRC will now trim long lines as per the RFC. This behaviour will be available in the CPAN release 4.70 Cheers, Chris 'BinGOs' Williams
From: BINGOS [...] cpan.org
Download (untitled) / with headers
text/plain 622b
On Wed Feb 20 17:14:14 2008, martin.ferrari@gmail.com wrote: Show quoted text
> Hi, > > Today I discovered that a commit notification bot I wrote with > PoCo::IRC wes getting kicked out of the server with a "Request too > long" message. Inspection revealed that the PRIVMSG it sent to the > channel was causing the kick because the raw command was longer than > 512 bytes, including \r\n. It seems that my private irc server is one > of the few to enforce the limit, but that's what the rfc says, so it'd > be nice if your module did check it. > > Thanks for the nice and useful code! >
Sorry I meant to say 5.70 instead of 4.70 Doh.
Closing ticket. Again. I suck at this.
Subject: Re: [rt.cpan.org #33472] PoCo::IRC should trim long lines
Date: Sat, 23 Feb 2008 12:41:34 -0200
To: bug-POE-Component-IRC [...] rt.cpan.org
From: "Martín Ferrari" <martin.ferrari [...] gmail.com>
Download (untitled) / with headers
text/plain 281b
On Sat, Feb 23, 2008 at 7:47 AM, BINGOS via RT <bug-POE-Component-IRC@rt.cpan.org> wrote: Show quoted text
> Thanks for the ticket. POE::Component::IRC will now trim long lines as per > the RFC. > > This behaviour will be available in the CPAN release 4.70
Thanks Chris! -- Martín Ferrari
4.70 has been released.
Subject: Re: [rt.cpan.org #33472] PoCo::IRC should trim long lines
Date: Sun, 16 Mar 2008 22:12:32 -0300
To: bug-POE-Component-IRC [...] rt.cpan.org
From: "Martín Ferrari" <martin.ferrari [...] gmail.com>
Download (untitled) / with headers
text/plain 529b
On Mon, Mar 3, 2008 at 8:11 AM, BINGOS via RT <bug-POE-Component-IRC@rt.cpan.org> wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=33472 > > > 4.70 has been released.
Sorry for nagging again (and RT will surely reopen the bug). I'm upgrading the version of PoCo::IRC in Debian and saw that you added a long line ($long variable) for testing this in t/1_filter_compat.t, but don't actually use it. Just pointing this out because it looks like you forgot to complete the test. Thanks once again. -- Martín Ferrari
Download (untitled) / with headers
text/plain 114b
Thanks for the pointer. The test suite will be revamped soon, adding tests for this feature, among other things.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.