Skip Menu |
 

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 33089
Status: resolved
Priority: 0/
Queue: DBD-Pg

People
Owner: Nobody in particular
Requestors: trevorinman9 [...] yahoo.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.0.0
Fixed in: 2.1.0



Subject: 2.0.0_9: Build break when compiling with 'gcc -ansi'
Download (untitled) / with headers
text/plain 587b
In 2.0.0_9, the dbdimp.c file contains a few C++-style comments. When compiling via gcc with the -ansi option, C++-style comments aren't allowed in C files. Please convert to /* */ comments. Patch attached. Also, 2.0.0 isn't currently an option for the "Broken in" field when submitting bugs. Might want to fix that. :) Environment: DBD::Pg version: 2.0.0_9 perl -v: This is perl, v5.8.5 built for x86_64-linux-ld uname -a: Linux dev-linux06 2.6.9-42.ELsmp #1 SMP Tue Aug 15 10:35:26 BST 2006 x86_64 x86_64 x86_64 GNU/Linux gcc --version: gcc (GCC) 3.4.6 20060404 (Red Hat 3.4.6-9)
Subject: DBD-Pg-comment-fix.patch
928c928 < //fieldname = newSVpv(PQfname(imp_sth->result, fields),0); --- > /* fieldname = newSVpv(PQfname(imp_sth->result, fields),0); */ 1098c1098 < // unsigned int newval = SvTRUE(valuesv); --- > /* unsigned int newval = SvTRUE(valuesv); */ 2500c2500 < imp_dbh->async_sth = NULL; // Needed? --- > imp_dbh->async_sth = NULL; /* Needed? */
Download (untitled) / with headers
text/plain 173b
Thanks, now fixed in r10717. The new version numbers take time to percolate through the system and appear on rt.cpan.org, but they should eventually appear in the pulldowns.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.