Skip Menu |
 

This queue is for tickets about the Module-Load-Conditional CPAN distribution.

Report information
The Basics
Id: 32817
Status: resolved
Priority: 0/
Queue: Module-Load-Conditional

People
Owner: Nobody in particular
Requestors: ishigaki [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: $INC{'Module/Load/Conditional.pm'} isn't canonicalized under Win32
Download (untitled) / with headers
text/plain 183b
Hi, as $INC{'Module/Load/Conditional.pm'} isn't canonicalized under the Win32 (or, at least Win32 ActivePerl), t/01_Module_Load_Conditional.t fails. A patch to fix attached. Thanks.
Subject: Module-Load-Conditional-0.24.patch
diff -ur Module-Load-Conditional-0.24/t/01_Module_Load_Conditional.t Module-Load-Conditional-0.24-patched/t/01_Module_Load_Conditional.t --- Module-Load-Conditional-0.24/t/01_Module_Load_Conditional.t 2007-10-12 17:47:16.000000000 +0900 +++ Module-Load-Conditional-0.24-patched/t/01_Module_Load_Conditional.t 2008-01-31 10:42:51.806250000 +0900 @@ -64,8 +64,12 @@ ### and return it @path; }; - - is( $INC{'Module/Load/Conditional.pm'}, + my $inc_path = $INC{'Module/Load/Conditional.pm'}; + if ( $^O eq 'MSWin32' ) { + $inc_path = File::Spec->canonpath( $inc_path ); + $inc_path =~ s{\\}{/}g; # to meet with unix path + } + is( $inc_path, File::Spec::Unix->catfile(@rv_path), q[ Found proper file] );
Download (untitled) / with headers
text/plain 252b
On Wed Jan 30 20:48:38 2008, ISHIGAKI wrote: Show quoted text
> Hi, as $INC{'Module/Load/Conditional.pm'} isn't canonicalized under the > Win32 (or, at least Win32 ActivePerl), t/01_Module_Load_Conditional.t > fails. A patch to fix attached. Thanks.
Thanks, applied.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.