Skip Menu |
 

This queue is for tickets about the XML-XPath CPAN distribution.

Report information
The Basics
Id: 32233
Status: resolved
Priority: 0/
Queue: XML-XPath

People
Owner: MANWAR [...] cpan.org
Requestors: jettero [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.13
Fixed in: 1.18



Subject: XML::XPath::Parser
Download (untitled) / with headers
text/plain 883b
When sub PrimaryExpr detects a bad token, it dies with a "\n", leaving the programmer of the bad expression wondering what died, where, and why. The only recourse, for such a programmer, (like myself), is to put... warn "here"; ... statements above and below each line of code to try to find the offending one. Typically, you'd want to use Carp::croak() to return the error to the programmer, and if it's inconvenient to do so (or to re-write it to be meaningful for the programmer), then you should at least leave the "\n" off so the programmer can source dive the XPath::Parser.pm module to find out what's generating the error... This line immediately triggerd 20 minutes of debugging for me: die "Not a PrimaryExpr at ", $tokens->[$self->{_tokpos}], "\n"; Grrrs. But please don't take this rant to mean that I dislike XML::XPath. It's still one of my favorite modules!
From: jettero [...] cpan.org
Also, sorry for the very bad title. I hit [create] before I was really ready. :(
Resolved.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.