|Subject:||"Use IO::Interactive::is_interactive() instead of -t" dubious?|
$ echo "use strict; -t FOO" | perlcritic Use IO::Interactive::is_interactive() instead of -t at line 1, column 14. See page 218 of PBP. (Severity: 5) I have several problems with this critique. First of all, it's recommending a 0.0.3 module trading off whatever perceived bugs using -t might have with whatever actual bugs that module has. Looking at what is_interactive() does, I'm not sure I agree with it's algorithm either. Second, using -t isn't always about determining if we're interactive, as illustrated above. At best, only -t STDIN or STDOUT should be warned about. Finally, is this really an issue of highest severity?