Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 30973
Status: stalled
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: domm [...] cpan.org
Requestors: cjm [...] cpan.org
JACOB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: v0.74
Fixed in: (no value)



Subject: prereq catches conditional ueses in test
Download (untitled) / with headers
text/plain 455b
From the Test::POD docs: Show quoted text
>eval "use Test::Pod 1.00"; > >plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
---but the prereq metric will fire on this... PS: Unrelated but I don't want to create a ticket for it: I think the changes metric should also check for a CHANGES section in the POD (as h2xs creates). I prefer to have the changes listed there because the changes file will not be available after the module has been installed.
Download (untitled) / with headers
text/plain 180b
Hi! The issue with reporting a prereq on Test::Pod etc is sort of fixed now, but in a slightly too hackish way. WRT Changes, I'll take a look into this. Thanks for the feedback!
Download (untitled) / with headers
text/plain 135b
It's certainly not completely fixed. http://cpants.perl.org/dist/kwalitee/WebService-NFSN still claims it requires Test::Perl::Critic.
Download (untitled) / with headers
text/plain 574b
On Thu Apr 17 05:12:23 2008, CJM wrote: Show quoted text
> It's certainly not completely fixed. > http://cpants.perl.org/dist/kwalitee/WebService-NFSN still claims it > requires Test::Perl::Critic.
For the record, the failing code is the following. Module::ExtractUse can detect common "use"s in eval blocks, but I'm not sure if it would be able to handle this too, especially without any significant performance penalty. ------------------- eval <<''; use Test::Perl::Critic (qw(-verbose 10 -exclude) => ['ProhibitAccessOfPrivateData']); -------------------


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.