Skip Menu |
 

This queue is for tickets about the Locale-US CPAN distribution.

Report information
The Basics
Id: 30949
Status: resolved
Worked: 10 min
Priority: 0/
Queue: Locale-US

People
Owner: metaperl [...] gmail.com
Requestors: janus [...] errornet.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 1.1
  • 1.2
Fixed in:
  • 1.1
  • 1.2



Subject: Patch to remove debugging leftovers
Download (untitled) / with headers
text/plain 133b
The module is using Data::Dumper even though the only line using it is commented out. The patch removes the use line and the comment.
Subject: US_pm.diff
Download US_pm.diff
text/x-diff 328b
--- ../Locale-US-1.2.orig/US.pm Sat Nov 24 14:29:32 2007 +++ US.pm Sat Nov 24 14:38:55 2007 @@ -4,8 +4,6 @@ use strict; use warnings; -use Data::Dumper; - require Exporter; our @ISA = qw(Exporter); @@ -46,7 +44,6 @@ $self->{state2code}{$state} = $code; } -# warn Dumper $self; bless $self, $class; }
fixed. thanks.
From: paul [...] city-fan.org
Download (untitled) / with headers
text/plain 702b
On Thu Apr 02 13:43:20 2009, TBONE wrote: Show quoted text
> fixed. thanks.
2.112140 has warnings left in the new() method, resulting in: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t my (AL, ALABAMA) = split ':'; at /builddir/build/BUILD/Locale-US-2.112140/blib/lib/Locale/US.pm line 30, <DATA> line 212. my (AK, ALASKA) = split ':'; at /builddir/build/BUILD/Locale-US-2.112140/blib/lib/Locale/US.pm line 30, <DATA> line 212. my (AS, AMERICAN SAMOA) = split ':'; at /builddir/build/BUILD/Locale-US-2.112140/blib/lib/Locale/US.pm line 30, <DATA> line 212. ... etc. Attached patch removes left-over debugging code.
Subject: Locale-US-2.112140-rt30949.patch
--- Locale-US-2.112140/lib/Locale/US.pm.orig 2011-08-03 00:11:06.000000000 +0100 +++ Locale-US-2.112140/lib/Locale/US.pm 2011-08-03 14:14:49.310779375 +0100 @@ -7,8 +7,6 @@ use strict; use warnings; -use Data::Dumper; - use Data::Section::Simple; # Preloaded methods go here. @@ -19,21 +17,17 @@ my $self = {} ; my $data = Data::Section::Simple::get_data_section('states'); - #die "data: $data"; my @line = split "\n", $data; - #die "LINE: @line"; for ( @line ) { my ($code, $state) = split ':'; - warn " my ($code, $state) = split ':';"; $self->{code2state}{$code} = $state; $self->{state2code}{$state} = $code; } - #die Dumper $self; bless $self, $class; }
Wow. Fixed. Thanks again.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.