Skip Menu |
 

This queue is for tickets about the Module-Install CPAN distribution.

Report information
The Basics
Id: 30637
Status: resolved
Priority: 0/
Queue: Module-Install

People
Owner: Nobody in particular
Requestors: chisel [...] chizography.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.68
Fixed in: (no value)



Subject: Problem with files in directories whose name starts with 'inc'
Download (untitled) / with headers
text/plain 905b
There's a problem with "make dist" if you have any files inside a directory whose name starts with "inc"; e.g. 'incoming/patches/fix_a_bug.sql' This is due to check_manifest() in Module::Install::Admin::Manifest having a regexp that isn't strict enough, so it matched incorrect entries from the MANIFEST file, and prompts with the following (because there's no such file in inc/): Show quoted text
---- cut here ---- /usr/bin/perl "-Iinc" -I. "-MModule::Install::Admin" -e "dist_preop(q(Parley-0.58_01))" It appears that your MANIFEST does not contain the same components that are currently in the 'inc' directory. Please try running 'make manifest' and then run 'make dist' again. Remember to use the MANIFEST.SKIP file to control things that should not end up in your MANIFEST. See 'perldoc ExtUtils::Manifest' for details.
---- cut here ---- I've attached a patch against 0.68 which I believe resolves the issue.
Subject: module-install_0.68_inc.patch
--- /usr/local/share/perl/5.8.8/Module/Install/Admin/Manifest.pm-0.68 2007-11-10 11:01:51.000000000 +0000 +++ /usr/local/share/perl/5.8.8/Module/Install/Admin/Manifest.pm 2007-11-10 11:03:39.000000000 +0000 @@ -60,7 +60,7 @@ $path =~ s/\s.*//; $path =~ s/^\.[\\\/]//; $path =~ s/[\\\/]/\//g; - next unless $path =~ m!^\Q$prefix\E!i; + next unless $path =~ m!^\Q$prefix\E(?:/|$)!i; $manifest{$path} = \$manifest->[$i]; }
Resolved, but with a slightly different implementation. Will appear in 0.78.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.