This queue is for tickets about the DBIx-DBSchema CPAN distribution.

Report information
The Basics
Id:
30612
Status:
open
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
gthorisson [...] gmail.com
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
  • 0.01
  • 0.11
  • 0.13
  • 0.14
  • 0.15
  • 0.16
  • 0.17
  • 0.18
  • 0.19
  • 0.20
  • 0.21
  • 0.22
  • 0.23
  • 0.24
  • 0.25
  • 0.26
  • 0.27
  • 0.28
  • 0.29
  • 0.30
  • 0.31
  • 0.32
  • 0.33
  • 0.34
  • 0.35
Fixed in:
(no value)



Subject: Incorrect handling of signed/unsigned number in mysql driver
Date: Fri, 9 Nov 2007 13:16:01 +0000
To: bug-DBIx-DBSchema@rt.cpan.org
From: "Gudmundur A. Thorisson" <gthorisson@gmail.com>
Hi there. I want to report a problem in DBIx::DBSchema::DBD::mysql, latest version (0.35). When iterating over the columns in a table, the driver ignores the fact that numeric columns can have the unsigned attribute (e.g. int(10) unsigned ) . Here's a sample table- definition and the change to the regexp in line 45 in mysql.pm that makes it work with my schema: CREATE TABLE `Marker` ( `AutoMarkerID` int(10) unsigned NOT NULL auto_increment, `MarkerID` varchar(15) default NULL COMMENT 'HGVbase-assigned identifier for the marker', `IsDead` char(1) default NULL COMMENT 'Flag for specifying whether marker is deleted or not', `VariationType` varchar(30) NOT NULL COMMENT 'SO term for the type of the marker feature', `Source` varchar(20) NOT NULL, `LocalID` varchar(20) NOT NULL, `HotlinkID` int(10) unsigned default NULL, `ValidationCode` tinyint(2) unsigned default NULL COMMENT '0 to 31, as in ValidationCode table', PRIMARY KEY (`AutoMarkerID`), UNIQUE KEY `SourceDB` (`Source`,`LocalID`), UNIQUE KEY `MarkerID` (`MarkerID`), KEY `VariationType` (`VariationType`), KEY `HotlinkID` (`HotlinkID`) ) ENGINE=InnoDB DEFAULT CHARSET=latin1; 45c45 < $_->{'Type'} =~ /^(\w+)\(?([^)]+)?\)?( \d+)?/ ---
Show quoted text
> $_->{'Type'} =~ /^(\w+)\(?([^)]+)?\)?( \d+)?$/
Mummi ----------------------------------------------------------- Gudmundur A. Thorisson, PhD student, Brookes lab Department of Genetics University of Leicester University Road Leicester, LE1 7RH, UK E-mail: gthorisson@gmail.com Tel: +44 (0)116 252-3055
Please let me know why this patch wasn't applied. The current situation is that it fails silently (you don't bother to catch errors in your eval's). The situation with the patch applied is that "unsigned" or "zerofill" won't show in the schema produced by this module. Regards Racke
RT-Send-CC: racke@linuxia.de
On Thu Jul 08 05:54:18 2010, HORNBURG wrote:
Show quoted text
> Please let me know why this patch wasn't applied.
Stefan, No specific reason, mostly a general lack of time and not using a wide enough range of features across enough databases myself. If you'd like to help with DBIx::DBSchema development and maintenance, I'd be happy to have the help. I can make you a co-maint on CPAN and/or give you access to the CVS repository.
Show quoted text
> The current situation > is that it fails silently (you don't bother to catch errors in your > eval's). The situation with the patch applied is that "unsigned" or > "zerofill" won't show in the schema produced by this module.
None of the above options sound that great. Ideally unsigned/zerofill can make it into the 'local' bit, no?
Subject: Re: [rt.cpan.org #30612] Incorrect handling of signed/unsigned number in mysql driver
Date: Fri, 13 Aug 2010 20:03:48 +0200
To: bug-DBIx-DBSchema@rt.cpan.org
From: "Stefan Hornburg (Racke)" <racke@linuxia.de>
On 07/28/2010 01:07 AM, Ivan Kohler via RT wrote:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=30612> > > On Thu Jul 08 05:54:18 2010, HORNBURG wrote:
>> Please let me know why this patch wasn't applied.
> > Stefan, > > No specific reason, mostly a general lack of time and not using a wide > enough range of features across enough databases myself. > > If you'd like to help with DBIx::DBSchema development and maintenance, > I'd be happy to have the help. I can make you a co-maint on CPAN and/or > give you access to the CVS repository.
Yes, please do so. That makes it easier for me to put fixes etc and help with development and maintenance.
Show quoted text
>
>> The current situation >> is that it fails silently (you don't bother to catch errors in your >> eval's). The situation with the patch applied is that "unsigned" or >> "zerofill" won't show in the schema produced by this module.
> > None of the above options sound that great. Ideally unsigned/zerofill > can make it into the 'local' bit, no? >
OK. Regards Racke -- LinuXia Systems => http://www.linuxia.de/ Expert Interchange Consulting and System Administration ICDEVGROUP => http://www.icdevgroup.org/ Interchange Development Team
RT-Send-CC: racke@linuxia.de
On Fri Aug 13 14:04:01 2010, HORNBURG wrote:
Show quoted text
> On 07/28/2010 01:07 AM, Ivan Kohler via RT wrote:
> > > > If you'd like to help with DBIx::DBSchema development and > > maintenance, I'd be happy to have the help. I can make you a > > co-maint on CPAN and/or give you access to the CVS repository.
> > Yes, please do so. That makes it easier for me to put fixes etc and > help with development and maintenance.
Okay, I've send connection information privately and also made you a co-maint on CPAN.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.