Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 30097
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: MARKSTOS [...] cpan.org
Requestors: saj_btcrd [...] thecommune.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: optgroup for scrolling_list
Download (untitled) / with headers
text/plain 141b
Using optgroups in the values of scrolling_list doesn't work the way it does with popup_menu even though the HTML tags are the same for both.
Subject: Needs Test: optgroup for scrolling_list
Download (untitled) / with headers
text/plain 314b
On Thu Oct 18 12:31:24 2007, stu42j wrote: Show quoted text
> Using optgroups in the values of scrolling_list doesn't work the way it > does with popup_menu even though the HTML tags are the same for both.
To proceed with possibility changing this, we'll first need an automated test which illustrates the current defect. Mark
From: Stuart Johnston
Download (untitled) / with headers
text/plain 463b
Here is a patch adding three tests to form.t - One for optgroup itself, and one each for optgroup used with popup_menu and scrolling_list. The first two pass with 3.43. The final test is for this bug. There is also a source patch with a simple copy-paste implementation of the fix. I believe that there are only two differences between popup_menu and scrolling_list (size and multiple) so it might be better to refactor the common code into a single function.
Download CGI.pm-30097-test
application/octet-stream 2.4k

Message body not shown because it is not plain text.

Download CGI.pm-30097-patch
application/octet-stream 1.5k

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 581b
On Sat Jul 25 17:57:17 2009, http://saj.thecommune.net/ wrote: Show quoted text
> Here is a patch adding three tests to form.t - One for optgroup itself, > and one each for optgroup used with popup_menu and scrolling_list. The > first two pass with 3.43. The final test is for this bug. > > There is also a source patch with a simple copy-paste implementation of > the fix. I believe that there are only two differences between > popup_menu and scrolling_list (size and multiple) so it might be better > to refactor the common code into a single function.
Great! Thanks for the help. Mark
Thanks, this patch has been applied in my git repo now.
Subject: released, thanks.
I believe this change was released today as part of CGI.pm 3.45. Thanks for the contribution.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.