This queue is for tickets about the IMDB-Film CPAN distribution.

Report information
The Basics
Id:
29908
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
mat [...] mshopf.de
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
0.31



Subject: Cast format changed...
Date: Thu, 11 Oct 2007 00:27:04 +0200
To: bug-IMDB-Film@rt.cpan.org
From: Matthias Hopf <mat@mshopf.de>
Noticed with current CPAN IMDB::Film (0.30): Casts have now <a..> tags not only in the actor but also in the cast field. Some, at least. In these cases, the cast isn't detected any more. Trivial fix: ------> CUT <------- --- /var/tmp/IMDB-Film-0.30/lib/IMDB/Film.pm 2007-09-13 08:38:30.000000000 +0200 +++ Film.pm 2007-10-11 00:21:50.000000000 +0200 @@ -643,7 +643,7 @@ if($tag->[1]{href} && $tag->[1]{href} =~ m#(?<!tinyhead)/name/nm(\d+?)/#) { $person = $parser->get_text; $id = $1; - my $text = $parser->get_trimmed_text('a', '/tr'); + my $text = $parser->get_trimmed_text('/tr'); ($role) = $text =~ /.*?\s+(.*)$/; push @cast, {id => $id, name => $person, role => $role}; } ------> CUT <------- Thanks Matthias -- Matthias Hopf <mhopf@suse.de> __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ labs www.mshopf.de
Subject: Re: [rt.cpan.org #29908] Cast format changed...
Date: Mon, 15 Oct 2007 22:43:54 +0400
To: bug-IMDB-Film@rt.cpan.org
From: "Michael Stepanov" <stepanov.michael@gmail.com>
Thanks for your bug-report. I'll able to fix that problem next week only because I'm on vacation now. On 10/11/07, Matthias Hopf via RT <bug-IMDB-Film@rt.cpan.org> wrote:
Show quoted text
> > Wed Oct 10 18:30:50 2007: Request 29908 was acted upon. > Transaction: Ticket created by mat@mshopf.de > Queue: IMDB-Film > Subject: Cast format changed... > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: mat@mshopf.de > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=29908 > > > > Noticed with current CPAN IMDB::Film (0.30): > > Casts have now <a..> tags not only in the actor but also in the cast > field. Some, at least. In these cases, the cast isn't detected any more. > > Trivial fix: > > ------> CUT <------- > --- /var/tmp/IMDB-Film-0.30/lib/IMDB/Film.pm 2007-09-13 08:38:30.000000000 +0200 > +++ Film.pm 2007-10-11 00:21:50.000000000 +0200 > @@ -643,7 +643,7 @@ > if($tag->[1]{href} && $tag->[1]{href} =~ m#(?<!tinyhead)/name/nm(\d+?)/#) { > $person = $parser->get_text; > $id = $1; > - my $text = $parser->get_trimmed_text('a', '/tr'); > + my $text = $parser->get_trimmed_text('/tr'); > ($role) = $text =~ /.*?\s+(.*)$/; > push @cast, {id => $id, name => $person, role => $role}; > } > ------> CUT <------- > > Thanks > > Matthias > > -- > Matthias Hopf <mhopf@suse.de> __ __ __ > Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de > Phone +49-911-74053-715 __) |_| __) |__ labs www.mshopf.de > >
-- Best regards, Michael Stepanov, www.stepanoff.org
Subject: Re: [rt.cpan.org #29908] Cast format changed...
Date: Tue, 16 Oct 2007 17:37:52 +0200
To: Michael Stepanov via RT <bug-IMDB-Film@rt.cpan.org>
From: Matthias Hopf <mat@mshopf.de>
On Oct 15, 07 14:44:39 -0400, Michael Stepanov via RT wrote:
Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=29908 > > > Thanks for your bug-report. I'll able to fix that problem next week > only because I'm on vacation now.
No probs. I have it fixed for myself. I just wanted to report this ASAP so it's not lost. Thanks for IMDB::Film :) Matthias -- Matthias Hopf <mhopf@suse.de> __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ labs www.mshopf.de


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.