Skip Menu |
 
rt.cpan.org will be shut down on March 1st, 2021.

This queue is for tickets about the Module-Starter-PBP CPAN distribution.

Report information
The Basics
Id: 29844
Status: new
Priority: 0/
Queue: Module-Starter-PBP

People
Owner: Nobody in particular
Requestors: LIMAONE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Patch for several tickets
Download (untitled) / with headers
text/plain 133b
the attached patch fixes several minor bugs and updates the perlcritic test file to the latest recommended one. best regards, markus
Subject: MSPBP.patch
Download MSPBP.patch
text/x-diff 1.3k
4c4 < use version; $VERSION = qv('0.0.3'); --- > use version; $VERSION = qv('0.0.4'); 234a235 > ['t', 'perlcriticrc'], 611c612 < use version; $VERSION = qv('0.0.3'); --- > use version; our $VERSION = qv('0.0.1'); 743c744 < !=head1 LICENCE AND COPYRIGHT --- > !=head1 LICENSE AND COPYRIGHT 790,793c791,799 < if (!require Test::Perl::Critic) { < Test::More::plan( < skip_all => "Test::Perl::Critic required for testing PBP compliance" < ); --- > use strict; > use warnings; > use File::Spec; > use Test::More; > use English qw(-no_match_vars); > > if ( not $ENV{TEST_AUTHOR} ) { > my $msg = 'Author test. Set $ENV{TEST_AUTHOR} to a true value to run.'; > plan( skip_all => $msg ); 796c802,822 < Test::Perl::Critic::all_critic_ok(); --- > eval { require Test::Perl::Critic; }; > > if ( $EVAL_ERROR ) { > my $msg = 'Test::Perl::Critic required to criticise code'; > plan( skip_all => $msg ); > } > > my $rcfile = File::Spec->catfile( 't', 'perlcriticrc' ); > Test::Perl::Critic->import( -profile => $rcfile ); > all_critic_ok(); > _____[ perlcriticrc ]___________________________________________________ > severity=1 > # we use Fatal qw(open close) > #[-InputOutput::RequireCheckedOpen] > #[-InputOutput::RequireCheckedClose] > > [Documentation::RequirePodSections] > source = module_starter_pbp_0_0_3 > language = en_US > > [-Miscellanea::RequireRcsKeywords]


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.