Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CPAN-Reporter CPAN distribution.

Report information
The Basics
Id: 29751
Status: resolved
Priority: 0/
Queue: CPAN-Reporter

People
Owner: dagolden [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.99_14
Fixed in: 1.00



Subject: CPAN::Reporter almost builds with 5.005_05
Download (untitled) / with headers
text/plain 1.2k
Besides the fight to get the prerequisites of CPAN::Reporter running with perl5.005_05, there was not much to do for CPAN::Reporter itself: First, Fcntl.pm does not export :seek or SEEK_END. To get SEEK_END, one has to import it from POSIX: diff -up 'build/CPAN-Reporter-0.99_14-zDhuPO/lib/CPAN/Reporter/History.pm' 'new.build/CPAN-Reporter-0.99_14/lib/CPAN/Reporter/History.pm' Index: ./lib/CPAN/Reporter/History.pm --- ./lib/CPAN/Reporter/History.pm Tue Oct 2 22:11:34 2007 +++ ./lib/CPAN/Reporter/History.pm Wed Oct 3 23:22:55 2007 @@ -2,7 +2,14 @@ package CPAN::Reporter::History; $VERSION = '0.99_14'; ## no critic use strict; use Config; -use Fcntl qw/:flock :seek/; +use Fcntl qw/:flock/; +BEGIN { + if ($] < 5.006) { + eval 'use POSIX qw/SEEK_END/'; + } else { + eval 'use Fcntl qw/SEEK_END/'; + } +} use File::HomeDir (); use File::Path (qw/mkpath/); use File::Spec (); Second: there is a call "delete $array[$index]" which is not implemented in perl5.005 (only hash elems may be deleted). A workaround is to undef the array element instead, but this causes some tests to fail. I hope these test failures are rather harmless (not existant vs. undef). That's it! Regards, Slaven
Subject: Re: [rt.cpan.org #29751] CPAN::Reporter almost builds with 5.005_05
Date: Thu, 4 Oct 2007 00:59:15 -0400
To: bug-CPAN-Reporter [...] rt.cpan.org
From: "David Golden" <xdaveg [...] gmail.com>
Download (untitled) / with headers
text/plain 1.7k
Thanks very much. Which prereqs were a problem? David On 10/3/07, Slaven_Rezic via RT <bug-CPAN-Reporter@rt.cpan.org> wrote: Show quoted text
> > Wed Oct 03 17:57:57 2007: Request 29751 was acted upon. > Transaction: Ticket created by SREZIC > Queue: CPAN-Reporter > Subject: CPAN::Reporter almost builds with 5.005_05 > Broken in: 0.99_14 > Severity: Normal > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=29751 > > > > Besides the fight to get the prerequisites of CPAN::Reporter running > with perl5.005_05, there was not much to do for CPAN::Reporter itself: > > First, Fcntl.pm does not export :seek or SEEK_END. To get SEEK_END, one > has to import it from POSIX: > > diff -up > 'build/CPAN-Reporter-0.99_14-zDhuPO/lib/CPAN/Reporter/History.pm' > 'new.build/CPAN-Reporter-0.99_14/lib/CPAN/Reporter/History.pm' > Index: ./lib/CPAN/Reporter/History.pm > --- ./lib/CPAN/Reporter/History.pm Tue Oct 2 22:11:34 2007 > +++ ./lib/CPAN/Reporter/History.pm Wed Oct 3 23:22:55 2007 > @@ -2,7 +2,14 @@ package CPAN::Reporter::History; > $VERSION = '0.99_14'; ## no critic > use strict; > use Config; > -use Fcntl qw/:flock :seek/; > +use Fcntl qw/:flock/; > +BEGIN { > + if ($] < 5.006) { > + eval 'use POSIX qw/SEEK_END/'; > + } else { > + eval 'use Fcntl qw/SEEK_END/'; > + } > +} > use File::HomeDir (); > use File::Path (qw/mkpath/); > use File::Spec (); > > Second: there is a call "delete $array[$index]" which is not implemented > in perl5.005 (only hash elems may be deleted). A workaround is to undef > the array element instead, but this causes some tests to fail. I hope > these test failures are rather harmless (not existant vs. undef). > > That's it! > > Regards, > Slaven > >
CC: SREZIC [...] cpan.org
Subject: Re: [rt.cpan.org #29751] CPAN::Reporter almost builds with 5.005_05
Date: 04 Oct 2007 09:15:58 +0200
To: bug-CPAN-Reporter [...] rt.cpan.org
From: Slaven Rezic <slaven [...] rezic.de>
Download (untitled) / with headers
text/plain 2.6k
"David Golden via RT" <bug-CPAN-Reporter@rt.cpan.org> writes: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=29751 > > > Thanks very much. Which prereqs were a problem?
File-Temp - https://rt.cpan.org/Ticket/Display.html?id=26841 Test-Reporter - uses three-argument opens in a test script, otherwise seems to run fine Time-HiRes - https://rt.cpan.org/Ticket/Display.html?id=29747, which is really a problem of Devel::PPPort - https://rt.cpan.org/Ticket/Display.html?id=29748 Pod-Parser - https://rt.cpan.org/Ticket/Display.html?id=29749 File-Copy-Recursive - https://rt.cpan.org/Ticket/Display.html?id=29750 Regards, Slaven Show quoted text
> > David > > On 10/3/07, Slaven_Rezic via RT <bug-CPAN-Reporter@rt.cpan.org> wrote:
> > > > Wed Oct 03 17:57:57 2007: Request 29751 was acted upon. > > Transaction: Ticket created by SREZIC > > Queue: CPAN-Reporter > > Subject: CPAN::Reporter almost builds with 5.005_05 > > Broken in: 0.99_14 > > Severity: Normal > > Owner: Nobody > > Requestors: SREZIC@cpan.org > > Status: new > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=29751 > > > > > > > Besides the fight to get the prerequisites of CPAN::Reporter running > > with perl5.005_05, there was not much to do for CPAN::Reporter itself: > > > > First, Fcntl.pm does not export :seek or SEEK_END. To get SEEK_END, one > > has to import it from POSIX: > > > > diff -up > > 'build/CPAN-Reporter-0.99_14-zDhuPO/lib/CPAN/Reporter/History.pm' > > 'new.build/CPAN-Reporter-0.99_14/lib/CPAN/Reporter/History.pm' > > Index: ./lib/CPAN/Reporter/History.pm > > --- ./lib/CPAN/Reporter/History.pm Tue Oct 2 22:11:34 2007 > > +++ ./lib/CPAN/Reporter/History.pm Wed Oct 3 23:22:55 2007 > > @@ -2,7 +2,14 @@ package CPAN::Reporter::History; > > $VERSION = '0.99_14'; ## no critic > > use strict; > > use Config; > > -use Fcntl qw/:flock :seek/; > > +use Fcntl qw/:flock/; > > +BEGIN { > > + if ($] < 5.006) { > > + eval 'use POSIX qw/SEEK_END/'; > > + } else { > > + eval 'use Fcntl qw/SEEK_END/'; > > + } > > +} > > use File::HomeDir (); > > use File::Path (qw/mkpath/); > > use File::Spec (); > > > > Second: there is a call "delete $array[$index]" which is not implemented > > in perl5.005 (only hash elems may be deleted). A workaround is to undef > > the array element instead, but this causes some tests to fail. I hope > > these test failures are rather harmless (not existant vs. undef). > > > > That's it! > > > > Regards, > > Slaven > > > >
>
-- Slaven Rezic - slaven <at> rezic <dot> de tknotes - A knotes clone, written in Perl/Tk. http://ptktools.sourceforge.net/#tknotes
Subject: Re: [rt.cpan.org #29751] CPAN::Reporter almost builds with 5.005_05
Date: Thu, 4 Oct 2007 14:40:15 -0400
To: bug-CPAN-Reporter [...] rt.cpan.org
From: "David Golden" <xdaveg [...] gmail.com>
Download (untitled) / with headers
text/plain 414b
On 10/3/07, Slaven_Rezic via RT <bug-CPAN-Reporter@rt.cpan.org> wrote: Show quoted text
> First, Fcntl.pm does not export :seek or SEEK_END. To get SEEK_END, one > has to import it from POSIX:
I just hard-coded it as "2". Show quoted text
> Second: there is a call "delete $array[$index]" which is not implemented
Fixed. This was just a "pop @array" operation. The $array[$index] phrase was used for symmetry with other code around it. David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.