Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Reporter CPAN distribution.

Report information
The Basics
Id: 29690
Status: resolved
Priority: 0/
Queue: Test-Reporter

People
Owner: FHOXH [...] cpan.org
Requestors: janus [...] errornet.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 1.27
  • 1.29_01
  • 1.29_02
  • 1.29_03
  • 1.29_04
  • 1.30
  • 1.32
  • 1.34
Fixed in: (no value)



Subject: Fix for clean -dump output
Download (untitled) / with headers
text/plain 1018b
When cpantest is used with the -dump switch, at the end of the output appears the stringified STDOUT filehandle. As Test::Reporter::write() takes the filehandle to STDOUT there's no need to print the return value from write(). Made me wonder a few times already because i want to collect reports from various machines and send them out later from a central machine with smtp connectivity. Further i've added a linebreak to the end of the -dump output which makes it even nicer IMHO. A diff between the current releases -dump output and with my changes: --- /tmp/dump.a Mon Oct 1 11:27:08 2007 +++ /tmp/dump.b Mon Oct 1 11:27:11 2007 @@ -38,4 +38,4 @@ gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-R/usr/libdata/perl5/i386-openbsd/5.8.8/CORE' - cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC 'GLOB(0x8afc4f24) \ No newline at end of file + cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC ' Patch against git attached, regards Simon
Subject: cpantest.diff
Download cpantest.diff
text/x-diff 391b
diff --git a/bin/cpantest b/bin/cpantest index 28131eb..249eeac 100644 --- a/bin/cpantest +++ b/bin/cpantest @@ -47,7 +47,8 @@ $Reporter = Test::Reporter->new(); if ($Dump) { my $fh; open($fh, '>-') or die "Can't open STDOUT: $!"; - print $Reporter->write($fh); + $Reporter->write($fh); + print $fh "\n"; } else { &confirm_send() if not $Automatic; &send();
From: FHOXH [...] cpan.org
Download (untitled) / with headers
text/plain 1.1k
On Mon Oct 01 05:30:49 2007, janus wrote: Show quoted text
> When cpantest is used with the -dump switch, at the end of the output > appears the stringified STDOUT filehandle. > As Test::Reporter::write() takes the filehandle to STDOUT there's > no need to print the return value from write(). Made me wonder a > few times already because i want to collect reports from various machines > and send them out later from a central machine with smtp connectivity. > > Further i've added a linebreak to the end of the -dump output which makes > it even nicer IMHO. > > A diff between the current releases -dump output and with my changes: > --- /tmp/dump.a Mon Oct 1 11:27:08 2007 > +++ /tmp/dump.b Mon Oct 1 11:27:11 2007 > @@ -38,4 +38,4 @@ > gnulibc_version='' > Dynamic Linking: > dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, > ccdlflags='-Wl,-R/usr/libdata/perl5/i386-openbsd/5.8.8/CORE' > - cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC 'GLOB(0x8afc4f24) > \ No newline at end of file > + cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC ' > > Patch against git attached,
Simon, Thanks so much for the patch. A new release of T::R going out in a few minutes will include it.
Subject: Re: [rt.cpan.org #29690] Fix for clean -dump output
Date: Tue, 9 Oct 2007 09:37:01 +0200
To: "Adam J. Foxson via RT" <bug-Test-Reporter [...] rt.cpan.org>
From: Simon Bertrang <janus [...] errornet.de>
Download (untitled) / with headers
text/plain 1.4k
On Mon, Oct 08, 2007 at 08:53:42PM -0400, Adam J. Foxson via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=29690 > > > On Mon Oct 01 05:30:49 2007, janus wrote:
> > When cpantest is used with the -dump switch, at the end of the output > > appears the stringified STDOUT filehandle. > > As Test::Reporter::write() takes the filehandle to STDOUT there's > > no need to print the return value from write(). Made me wonder a > > few times already because i want to collect reports from various machines > > and send them out later from a central machine with smtp connectivity. > > > > Further i've added a linebreak to the end of the -dump output which makes > > it even nicer IMHO. > > > > A diff between the current releases -dump output and with my changes: > > --- /tmp/dump.a Mon Oct 1 11:27:08 2007 > > +++ /tmp/dump.b Mon Oct 1 11:27:11 2007 > > @@ -38,4 +38,4 @@ > > gnulibc_version='' > > Dynamic Linking: > > dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, > > ccdlflags='-Wl,-R/usr/libdata/perl5/i386-openbsd/5.8.8/CORE' > > - cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC 'GLOB(0x8afc4f24) > > \ No newline at end of file > > + cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC ' > > > > Patch against git attached,
> > Simon, > > Thanks so much for the patch. A new release of T::R going out in a few minutes will include > it.
Cool. I've just updated our port and will commit it soon without local patches. Thanks a lot for your work and the notice. Regards, Simon


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.