Skip Menu |
 

This queue is for tickets about the DBD-mysql CPAN distribution.

Report information
The Basics
Id: 2966
Status: resolved
Priority: 0/
Queue: DBD-mysql

People
Owner: jwied [...] cpan.org
Requestors: andreas.koenig [...] anima.de
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.9002
Fixed in: (no value)

Attachments


Subject: myld buglet
Download (untitled) / with headers
text/plain 387b
RUDY/DBD-mysql-2.9002.tar.gz has a myld script that does not react sensibly on compile errors. Makeing the script strict clean immediately reveals the bug. The attached patch should be enough to fix it. The symptom I had to fix was that the compilation complained about missing ssl library, but the myld script just returned the error status 1 and no error message. My patch fixes this.
--- DBD-mysql-2.9002-ak/myld Wed Jul 16 11:42:45 2003 +++ DBD-mysql-2.9002/myld Tue Mar 18 03:53:27 2003 @@ -4,18 +4,16 @@ # in the linking stage # -use strict; open(OLDSTDERR, ">&STDERR") || die "Failed to backup STDERR: $!"; open(FILE, ">myld.stderr") || die "Failed to create myld.stderr: $!"; open(STDERR, ">&FILE") || die "Failed to redirect STDERR: $!"; -my $retval = system @ARGV; +$retval = system @ARGV; open(STDERR, ">&OLDSTDERR"); close(FILE) || die "Failed to close myld.stderr: $!"; -my $contents; if (-f "myld.stderr" && !-z _) { open(FILE, "<myld.stderr") || die "Failed to reopen myld.stderr: $!"; local $/ = undef; - $contents = <FILE>; + my $contents = <FILE>; die "Failed to read myld.stderr: $!" unless defined($contents); close(FILE) || die "Failed to close myld.stderr: $!";
Ooops, I sent a reverse patch. Sorry! To be applied with the -R switch, obviously.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.