Skip Menu |
 

This queue is for tickets about the Crypt-SSLeay CPAN distribution.

Report information
The Basics
Id: 29372
Status: resolved
Priority: 0/
Queue: Crypt-SSLeay

People
Owner: dland [...] cpan.org
Requestors: JDB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 0.57



Subject: Erroneous assignment to $! in Net/SSL.pm
Download (untitled) / with headers
text/plain 442b
The connect method contains this code: # odd error in eval {} block, maybe alarm outside the evals if($@) { $! = "$@; $!"; croak($@); } The assignment should be to $@ and not to $! A little earlier we there is the following code: eval { $self->die_with_error("SSL negotiation failed") }; $@ = "$@; $!"; The assignment to $@ there becomes redundant once the code below is fixed.
Download (untitled) / with headers
text/plain 650b
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
Download (untitled) / with headers
text/plain 650b
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
Download (untitled) / with headers
text/plain 650b
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
Download (untitled) / with headers
text/plain 650b
On Fri Sep 14 14:33:28 2007, JDB wrote: Show quoted text
> The connect method contains this code: > > # odd error in eval {} block, maybe alarm outside the evals > if($@) { > $! = "$@; $!"; > croak($@); > } > > The assignment should be to $@ and not to $! > > A little earlier we there is the following code: > > eval { $self->die_with_error("SSL negotiation failed") }; > $@ = "$@; $!"; > > The assignment to $@ there becomes redundant once the code below is fixed.
Hmmm, well that's all quite silly isn't it. Thanks for noticing this, I'll get it straightened out in the next release. Thanks, David
Download (untitled) / with headers
text/plain 865b
On Sat Sep 15 05:17:55 2007, DLAND wrote: Show quoted text
> On Fri Sep 14 14:33:28 2007, JDB wrote:
> > The connect method contains this code: > > > > # odd error in eval {} block, maybe alarm outside the evals > > if($@) { > > $! = "$@; $!"; > > croak($@); > > } > > > > The assignment should be to $@ and not to $! > > > > A little earlier we there is the following code: > > > > eval { $self->die_with_error("SSL negotiation
failed") }; Show quoted text
> > $@ = "$@; $!"; > > > > The assignment to $@ there becomes redundant once the code below is
fixed. Show quoted text
> > Hmmm, well that's all quite silly isn't it. Thanks for noticing this, > I'll get it straightened out in the next release. > > Thanks, > David
Woah. Sorry about the 50 million replies. The RT server was just hanging there doing nothing... so I kept on trying. David
Fixed in release 0.57. Thanks for the report. David Landgren


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.