Skip Menu |
 

This queue is for tickets about the MailTools CPAN distribution.

Report information
The Basics
Id: 29361
Status: resolved
Priority: 0/
Queue: MailTools

People
Owner: Nobody in particular
Requestors: cogent [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.77
Fixed in: (no value)



Subject: $sender ignored between open() and exec()
Download (untitled) / with headers
text/plain 537b
In Mail/Mailer.pm, in the code for open() (specifically, on line 277 and again on line 284), there's a call to exec(): $self->exec($exe, $args, \@to, $sender) But exec() ignores this last argument (line 308), which should be used for, among other things, the envelope sender: my($self, $exe, $args, $to) = @_; The function is a short one; $sender is completely ignored throughout. The envelope sender can be a reasonably important thing, and there's a reasonable expectation that Mail::Send (and therefore Mail::Mailer) will use it.
Subject: Re: [rt.cpan.org #29361] $sender ignored between open() and exec()
Date: Fri, 14 Sep 2007 10:35:09 +0200
To: David Hand via RT <bug-MailTools [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
Download (untitled) / with headers
text/plain 1.7k
* David Hand via RT (bug-MailTools@rt.cpan.org) [070914 07:55]: Show quoted text
> Fri Sep 14 03:55:56 2007: Request 29361 was acted upon. > Transaction: Ticket created by COGENT > Queue: MailTools > Subject: $sender ignored between open() and exec() > Broken in: 1.77 > Severity: Normal > Owner: Nobody > Requestors: COGENT@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=29361 > > > > In Mail/Mailer.pm, in the code for open() (specifically, on line 277 and > again on line 284), there's a call to exec(): > > $self->exec($exe, $args, \@to, $sender) > > But exec() ignores this last argument (line 308), which should be used > for, among other things, the envelope sender: > > my($self, $exe, $args, $to) = @_; > > The function is a short one; $sender is completely ignored throughout. > The envelope sender can be a reasonably important thing, and there's a > reasonable expectation that Mail::Send (and therefore Mail::Mailer) will > use it.
Although Mail::Mailer::exec() does not use it, the module is extended by Mail::Mailer::*, of which some implementation (for instance the qmail) do use the sender field. I have at added the $sender argument to the remaining function prototypes, but will not look at the implementation to use it (it may break existing code, so takes quite some testing to be sure that the implementation is ok, and I have no time for that) You may take that challenge. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
fixed in 2.00_03


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.