Skip Menu |
 

This queue is for tickets about the DBIx-Class-Schema-Loader CPAN distribution.

Report information
The Basics
Id: 30568
Status: resolved
Priority: 0/
Queue: DBIx-Class-Schema-Loader

People
Owner: ilmari+cpan [...] ilmari.org
Requestors: ishigaki [...] cpan.org
SMPETERS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: [PATCH] Failures on Win32
Download (untitled) / with headers
text/plain 2.3k
I'm seeing the following failures on Win32. C:\CPAN~1\build\DBIx-Class-Schema-Loader-0.04002-hDDTYF>prove -bv t\22dump.t t\22dump....1..5 Dumping manual schema for DBICTest::Schema::1 to directory ./t/_dump ... Schema dump completed. ok 1 - no death with dump_directory set ok 2 # skip ActiveState perl produces additional warnings ok 3 # skip ActiveState perl produces additional warnings ok 4 # skip ActiveState perl produces additional warnings Dumping manual schema for DBICTest::Schema::2 to directory ./t/_dump ... Schema dump completed. ok 5 - no death with dump_directory set (overwrite1) Dumping manual schema for DBICTest::Schema::2 to directory ./t/_dump ... Deleting existing file './t/_dump/DBICTest/Schema/2.pm' due to 'really_erase_my files' setting Deleting existing file './t/_dump/DBICTest/Schema/2/Bar.pm' due to 'really_eras _my_files' setting Deleting existing file './t/_dump/DBICTest/Schema/2/Foo.pm' due to 'really_eras _my_files' setting Schema dump completed. ok 6 - no death with dump_directory set (overwrite2) unlink t\_dump\DBICTest\Schema\1\Bar.pm unlink t\_dump\DBICTest\Schema\1\Foo.pm rmdir t\_dump\DBICTest\Schema\1 unlink t\_dump\DBICTest\Schema\1.pm unlink t\_dump\DBICTest\Schema\2\Bar.pm unlink t\_dump\DBICTest\Schema\2\Foo.pm rmdir t\_dump\DBICTest\Schema\2 unlink t\_dump\DBICTest\Schema\2.pm rmdir t\_dump\DBICTest\Schema rmdir t\_dump\DBICTest rmdir ./t/_dump # Looks like you planned 5 tests but ran 1 extra. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED test 6 Failed 1/5 tests, 80.00% okay (less 3 skipped tests: 1 okay, 20.00%) Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t\22dump.t 255 65280 5 1 6 3 subtests skipped. Failed 1/1 test scripts. -1/5 subtests failed. Files=1, Tests=5, 1 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) Failed 1/1 test programs. -1/5 subtests failed. The patch below fixes the problem. $ diff -u t/22dump.t.old t/22dump.t --- t/22dump.t.old 2007-09-10 10:05:18.234375000 -0500 +++ t/22dump.t 2007-09-10 10:05:54.250000000 -0500 @@ -33,7 +33,7 @@ DBICTest::Schema::1->_loader_invoked(undef); SKIP: { - skip "ActiveState perl produces additional warnings", 3 + skip "ActiveState perl produces additional warnings", 2 if ($^O eq 'MSWin32'); my @warn_output;
Subject: t/22dump.t skips a bit too much on MSWin32
Download (untitled) / with headers
text/plain 138b
@warnings_regexes in t/22dump.t (line 44) has two entries now, so the number of skip (line 36) should be 2 instead of 3. Patch attached.
Subject: DBIx-Class-Schema-Loader-0.04003.patch
diff -ur DBIx-Class-Schema-Loader-0.04003/t/22dump.t DBIx-Class-Schema-Loader-0.04003-patched/t/22dump.t --- DBIx-Class-Schema-Loader-0.04003/t/22dump.t 2007-07-02 23:43:37.000000000 +0900 +++ DBIx-Class-Schema-Loader-0.04003-patched/t/22dump.t 2007-11-08 15:29:13.639000000 +0900 @@ -33,7 +33,7 @@ DBICTest::Schema::1->_loader_invoked(undef); SKIP: { - skip "ActiveState perl produces additional warnings", 3 + skip "ActiveState perl produces additional warnings", 2 if ($^O eq 'MSWin32'); my @warn_output;
Download (untitled) / with headers
text/plain 125b
I fixed this in a slightly different, more robust manner: it now skips the number of elements in the expected warnings array.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.