This queue is for tickets about the CPAN CPAN distribution.

Report information
The Basics
Id:
28438
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
MTHURN [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Normal
Broken in:
1.9101
Fixed in:
(no value)



Subject: pod regarding keep_source_where is WRONG
The configuration question regarding build_source_where, as well as the CPAN pod itself, incorrectly implies that the user can choose to NOT keep sources. Please delete the phrase "(if we do)" from CPAN.pm, and please delete the phrase "Unless you are accessing the CPAN via the filesystem directly" from FirstTime.pm -- - - Martin 'Kingpin' Thurn
Subject: Re: [rt.cpan.org #28438] pod regarding keep_source_where is WRONG
Date: Mon, 23 Jul 2007 13:14:53 -0700
To: bug-CPAN@rt.cpan.org
From: Michael G Schwern <schwern@pobox.com>
Martin Thurn via RT wrote:
Show quoted text
> The configuration question regarding build_source_where, as well as the > CPAN pod itself, incorrectly implies that the user can choose to NOT > keep sources. Please delete the phrase "(if we do)" from CPAN.pm, and > please delete the phrase "Unless you are accessing the CPAN via the > filesystem directly" from FirstTime.pm
I believe the intention there is to communicate that if you're accessing a local CPAN mirror via file URLs (example: file:///var/local/CPAN_mirror) then it will not store a copy of the source tarball in sources. My observations show that it doesn't. It does, however, create a directory for the author in authors/id/ The wording could be made clearer. Also the author directory probably shouldn't be created.
Subject: Re: [rt.cpan.org #28438] pod regarding keep_source_where is WRONG
Date: Sat, 28 Jul 2007 03:44:03 +0200
To: bug-CPAN@rt.cpan.org
From: andreas.koenig.7os6VVqR@franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Mon, 23 Jul 2007 16:15:55 -0400, "Michael G Schwern via RT" <bug-CPAN@rt.cpan.org> said:
Show quoted text
> Queue: CPAN > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28438 >
Show quoted text
> Martin Thurn via RT wrote:
>> The configuration question regarding build_source_where, as well as the >> CPAN pod itself, incorrectly implies that the user can choose to NOT >> keep sources. Please delete the phrase "(if we do)" from CPAN.pm, and >> please delete the phrase "Unless you are accessing the CPAN via the >> filesystem directly" from FirstTime.pm
Show quoted text
> I believe the intention there is to communicate that if you're accessing a > local CPAN mirror via file URLs (example: file:///var/local/CPAN_mirror) then > it will not store a copy of the source tarball in sources. My observations > show that it doesn't. It does, however, create a directory for the author in > authors/id/
Show quoted text
> The wording could be made clearer. Also the author directory probably > shouldn't be created.
I think I managed to improve wording: --- lib/CPAN/FirstTime.pm (revision 2880) +++ lib/CPAN/FirstTime.pm (local) @@ -1072,9 +1072,9 @@ keep_source_where => qq{ -Unless you are accessing the CPAN via the filesystem directly CPAN.pm -needs to keep the source files it downloads somewhere. Please supply a -directory where the downloaded files are to be kept.}, +Unless you are accessing the CPAN on your filesystem via a file: URL, +CPAN.pm needs to keep the source files it downloads somewhere. Please +supply a directory where the downloaded files are to be kept.}, build_cache_intro => qq{ I'm reluctant to fix the unneeded creation of the directory but made a note in the code to fix it next time I have something to change in that area. (Rev. 2069 in SVN) Thanks! -- andreas
Fixed in 6f12848 in master branch on github:andk/cpanpm


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.