Skip Menu |
 

This queue is for tickets about the Template-Alloy CPAN distribution.

Report information
The Basics
Id: 28280
Status: resolved
Priority: 0/
Queue: Template-Alloy

People
Owner: Nobody in particular
Requestors: TINITA [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.006
Fixed in: (no value)



Subject: bench_various_templaters.pl mistakes
Download (untitled) / with headers
text/plain 319b
hi, samples/benchmark/bench_various_templaters.pl has some mistakes. HTML::Template(::Compiled) have an option case_sensitive, not CASE_SENSITIVE. the option for file caching in HTML::Template::Compiled is called cache_dir, not file_cache_dir (i admit this is bad naming, i should probably change it). regards, tina
i have attached a patchfile.
Download patch
application/octet-stream 3.7k

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 356b
Thank you for the patch. It will be included in the 1.007 release. I'm not sure I have anything pending for release right now so I'm not sure when 1.007 will come out. The patch increased the performance of HTC_file by 5 to 6 times. HTML::Template::Compiled is a great benchmark to be shooting for. For in memory templates - it is very - very fast!
Download (untitled) / with headers
text/plain 277b
On Mo. 16. Jul. 2007, 05:54:11, TINITA wrote: Show quoted text
> the option for file caching in HTML::Template::Compiled is called > cache_dir, not file_cache_dir (i admit this is bad naming, i should > probably change it).
i fixed this in version 0.87 and works like in HTML::Template now.
I think the latest is now in sync.
I think the latest is now in sync.
From: cpan2 [...] tinita.de
Download (untitled) / with headers
text/plain 174b
On Fr. 02. Nov. 2007, 11:36:49, RHANDOM wrote: Show quoted text
> I think the latest is now in sync.
still, the samples/benchmark/bench_various_templaters.pl stats seem to be the old ones...
Download (untitled) / with headers
text/plain 344b
If you will check that the code is either in compliance with your most recent changes to HTML::Template::Compiled, and send me a patch if they are not (send me the patch for the proper parameters to be using for the string ref, file cache, and in memory tests) -- then I will apply any patches rerun the tests and release an updated Alloy.
From: cpan2 [...] tinita.de
Download (untitled) / with headers
text/plain 255b
On Mo. 05. Nov. 2007, 10:51:30, RHANDOM wrote: Show quoted text
> If you will check that the code is either in compliance [...]
no sorry, i meant the SAMPLE OUTPUT section in bench_various_templaters.pl. the code seems to be ok, only the example results didn't change =)
Download (untitled) / with headers
text/plain 197b
The results were updated on Nov 7 - two days after the request a year ago. I think everything should be in working order. And a test today recorded nearly the same results on the same computer.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.