Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 28120
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: DMITRI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.06
Fixed in: (no value)



Subject: Policy suggestion: complain about __END__ used for here-to documents.
Download (untitled) / with headers
text/plain 633b
I do not think it's a good style to use __END__ as the terminator for here-to documents. For instance, the following code passes perlcritic OK: ------------------------ use strict; use warnings; sub dude { print <<__END__; dude! __END__ } dude(); exit; ----------------------- And there are also real-life examples: http://www.google.com/codesearch?as_q=%3C%3C+*%5B%27%22%5D%3F__END__&btnG=Search+Code&hl=en&as_lang=perl&as_license_restrict=i&as_license=&as_package=&as_filename=&as_case= (Another reason is that we probably want to make life easier for other tools that parse Perl code that are not perl, such as ctags.)
Download (untitled) / with headers
text/plain 368b
I've implemented a policy named ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator in a branch called rt28120. It may need a different severity. The documentation may be lacking. Perhaps its themes are wrong (now set to "core maintenance"). Maybe it should go in some distribution other than core. Other than those questions, I think it's ready to go.
Download (untitled) / with headers
text/plain 157b
This has been completed and released in Perl-Critic-1.097_002. http://search.cpan.org/~elliotjs/Perl-Critic-1.097_002 Thank you for submitting this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.