Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the DBD-Oracle CPAN distribution.

Report information
The Basics
Id: 27542
Status: resolved
Priority: 0/
Queue: DBD-Oracle

People
Owner: champoux [...] pythian.com
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.19
Fixed in: 1.20

Attachments


Subject: More diagnostics in find_header in Makefile.PL
Download (untitled) / with headers
text/plain 402b
File::Find::find(...) dies if no directories are specified. This is the case in find_headers in Makefile.PL, if no of the @try directories could actually be find. The attached patch fixes this by skipping the call of File::Find::find and falling through to a better error message text. This problem was also mentioned at http://www.mail-archive.com/dbi-dev@perl.org/msg04390.html Regards, Slaven
Subject: dbd-oracle-makefilepl.diff
--- Makefile.PL.orig 2006-10-10 20:54:05.000000000 +0200 +++ Makefile.PL 2007-06-12 09:40:36.000000000 +0200 @@ -1413,14 +1413,15 @@ sub find_headers { unshift @try, $::opt_h if $::opt_h; @try = grep { -d $_ } @try; - my %h_file; - find( sub { - return unless /^o(ci.{3,4}|ratypes)\.h$/i; - my $dir = $File::Find::dir; - $h_file{$_} ||= $dir; # record first one found - print "Found $dir/$_\n" if $::opt_d; - }, @try); - + my %h_file; + if (@try) { + find( sub { + return unless /^o(ci.{3,4}|ratypes)\.h$/i; + my $dir = $File::Find::dir; + $h_file{$_} ||= $dir; # record first one found + print "Found $dir/$_\n" if $::opt_d; + }, @try); + } my %h_dir = reverse %h_file; # distinct first found dirs my @h_dir = keys %h_dir;
Ok I have added that change to the trunk version of DBD::ORacle and checked it in


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.