Skip Menu |
 

This queue is for tickets about the POE-Component-IRC CPAN distribution.

Report information
The Basics
Id: 26946
Status: resolved
Worked: 30 min
Priority: 0/
Queue: POE-Component-IRC

People
Owner: BINGOS [...] cpan.org
Requestors: tom+cpan [...] iplod.net
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 5.29
Fixed in: (no value)



Subject: Plugin::Proxy emits a warning if it receives an empty line from IRCd
Download (untitled) / with headers
text/plain 740b
Plugin::Proxy barfs if it receives an empty line from the IRCd. I'm not sure why it receives empty lines, but some IRC servers seem to send them. Simple patch below. There's probably a better place to catch this which would catch it globally, but this will fix the immediate issue. --- a/lib/POE/Component/IRC/Plugin/Proxy.pm 2007-05-06 16:50:00.000000000 +0930 +++ b/lib/POE/Component/IRC/Plugin/Proxy.pm 2007-05-06 16:50:51.000000000 +0930 @@ -119,6 +119,8 @@ my ($self,$irc) = splice @_, 0, 2; my $line = ${ $_[0] }; + return PCI_EAT_NONE unless defined $line; + return PCI_EAT_ALL if $line =~ /^PING\s*/; foreach my $wheel_id ( keys %{ $self->{wheels} } ) { $self->_send_to_client( $wheel_id, $line );
Patch applied and version 5.30 released to CPAN. Many thanks.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.