This queue is for tickets about the XML-LibXSLT CPAN distribution.

Report information
The Basics
Id:
269
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
matt [...] sergeant.org
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Date: Sat, 9 Feb 2002 09:20:23 +0000 (GMT)
From: Matt Sergeant <matt@sergeant.org>
To: <bug-XML-LibXSLT@rt.cpan.org>
Subject: XML::LibXSLT Makefile.PL patchlet (fwd)
-- <!-- Matt --> <:->Get a smart net</:->
Show quoted text
---------- Forwarded message ---------- Date: 09 Feb 2002 06:16:26 +0100 From: Andreas J. Koenig <andreas.koenig@anima.de> To: Matt Sergeant <matt@sergeant.org> Subject: XML::LibXSLT Makefile.PL patchlet Hi Matt, I believe that dieing in a Makefile.PL in general should be avoided, but early dieing is always an error. This patch delays dieing until the error message is more useful. At the same time it removes an inconsistency. - Tested when no libxml2 and no libxslt is installed or when libxml2 is installed but libxslt isn't: here we get a better error message - Tested when both libraries are installed but XML::LibXML isn't: here we get the benefit of CPAN.pm's PREREQ_PM handling --- Makefile.PL~ Wed Nov 14 13:11:45 2001 +++ Makefile.PL Sat Feb 9 05:37:56 2002 @@ -13,11 +13,6 @@ my $DEBUG = delete $config{DEBUG}; -require XML::LibXML; -if ($XML::LibXML::VERSION < 1.30) { - die "XML::LibXML 1.30 or higher required\n"; -} - # get libs and inc from gnome-config eval { print "running xslt-config... "; @@ -75,7 +70,7 @@ 'VERSION_FROM' => 'LibXSLT.pm', # finds $VERSION 'AUTHOR' => 'Matt Sergeant', 'ABSTRACT' => 'Interface to Gnome libxslt library', - 'PREREQ_PM' => { 'XML::LibXML' => "0.94", }, + 'PREREQ_PM' => { 'XML::LibXML' => "1.30", }, %config, ); Enjoy, -- andreas
Closing - this is a very old ticket not related to the current state of the code, although it reminded me to bump up PREREQ_PM for XML::LibXML to 1.59. -- Petr


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.