Skip Menu |
 

This queue is for tickets about the CGI-SSI CPAN distribution.

Report information
The Basics
Id: 26823
Status: resolved
Priority: 0/
Queue: CGI-SSI

People
Owner: Nobody in particular
Requestors: colin.fine [...] pace.co.uk
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.90
Fixed in: (no value)



Subject: _get_ua makes invalid call to LWP::UserAgent::new
Download (untitled) / with headers
text/plain 589b
In line 308, CGI::SSI::pm says: my $ua = LWP::UserAgent->new($ENV{HTTP_USER_AGENT} || ()); But like HTTP::Cookies, LWP::UserAgent::new takes a hash as its argument, not a list. This can be easily fixed by something like: my %conf; $conf{agent} = $ENV{HTTP_USER_AGENT} if $ENV{HTTP_USER_AGENT}; my $ua = LWP::UserAgent->new(%conf); but it is not serious because LWP::UserAgent::new has a default agent. However, as I shall argue in another RT, this is all moot, because 'include virtual' does not, and cannot, work with remote URL's, so I doubt that this code has ever been executed.
Subject: RE: [rt.cpan.org #26823] AutoReply: _get_ua makes invalid call to LWP::UserAgent::new
Date: Mon, 30 Apr 2007 12:15:32 +0100
To: "'bug-CGI-SSI [...] rt.cpan.org'" <bug-CGI-SSI [...] rt.cpan.org>
From: Colin Fine <colin.fine [...] pacemicro.com>
Download (untitled) / with headers
text/plain 2.5k
Sorry - this is a duplicate of 26822. rt.cpan.org gave me a 500 page, and I didn't know it had submitted the ticket. Show quoted text
> Colin Fine > Engineering Tools Group > Pace Micro Technology plc > Bringing Technology Home > > > Tel: +44 1274 538038 > Fax: +44 1274 532029 > Victoria Road, Saltaire, West Yorkshire. BD18 3LF www.pacemicro.com >
This E-mail and any attachments hereto are strictly confidential and intended solely for the addressee. If you are not the intended addressee please notify the sender by return and delete the message. You must not disclose, forward or copy this E-mail or attachments to any third party without the prior consent of the sender. Pace Micro Technology plc (registered in England and Wales no. 1672847) whose head office is based at Victoria Road, Saltaire, West Yorkshire, BD18 3LF, UK. Tel +44 (0) 1274 532000 Fax +44 (0) 1274 532010 and at http://www.pacemicro.com. Show quoted text
-----Original Message----- From: Bugs in CGI-SSI via RT [mailto:bug-CGI-SSI@rt.cpan.org] Sent: 30 April 2007 11:59 To: colin.fine@pace.co.uk Subject: [rt.cpan.org #26823] AutoReply: _get_ua makes invalid call to LWP::UserAgent::new Greetings, This message has been automatically generated in response to the creation of a trouble ticket regarding: "_get_ua makes invalid call to LWP::UserAgent::new", a summary of which appears below. There is no need to reply to this message right now. Your ticket has been assigned an ID of [rt.cpan.org #26823]. Your ticket is accessible on the web at: http://rt.cpan.org/Ticket/Display.html?id=26823 Please include the string: [rt.cpan.org #26823] in the subject line of all future correspondence about this issue. To do so, you may reply to this message. Thank you, bug-CGI-SSI@rt.cpan.org ------------------------------------------------------------------------- In line 308, CGI::SSI::pm says: my $ua = LWP::UserAgent->new($ENV{HTTP_USER_AGENT} || ()); But like HTTP::Cookies, LWP::UserAgent::new takes a hash as its argument, not a list. This can be easily fixed by something like: my %conf; $conf{agent} = $ENV{HTTP_USER_AGENT} if $ENV{HTTP_USER_AGENT}; my $ua = LWP::UserAgent->new(%conf); but it is not serious because LWP::UserAgent::new has a default agent. However, as I shall argue in another RT, this is all moot, because 'include virtual' does not, and cannot, work with remote URL's, so I doubt that this code has ever been executed. Click https://www.mailcontrol.com/sr/wQw0zmjPoHdJTZGyOCrrhg== to report this email as spam.
Setting duplicate ticket as resolved.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.