Skip Menu |
 

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 26535
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse

People
Owner: domm [...] cpan.org
Requestors: MTHURN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.69
Fixed in: 0.72



Subject: wrong directory delimiter in FindModules.pm
Download (untitled) / with headers
text/plain 320b
Line 125 of Module::CPANTS::Kwalitee::FindModules contains a match looking for forward-slash in the directory path. THIS ALWAYS FAILS ON MSWin32. And besides, you already have an in_basedir hash value. Change line 125 to this: my @in_basedir=grep { $_->{in_basedir} } @$modules; -- - - Martin 'Kingpin' Thurn
Subject: Re: [rt.cpan.org #26535] wrong directory delimiter in FindModules.pm
Date: Mon, 23 Apr 2007 09:52:30 +0200
To: Martin Thurn via RT <bug-Module-CPANTS-Analyse [...] rt.cpan.org>
From: Thomas Klausner <domm [...] cpan.org>
Download (untitled) / with headers
text/plain 1.1k
Hi! On Sat, Apr 21, 2007 at 05:11:30PM -0400, Martin Thurn via RT wrote: Show quoted text
> Line 125 of Module::CPANTS::Kwalitee::FindModules contains a match > looking for forward-slash in the directory path. THIS ALWAYS FAILS ON > MSWin32.
I tried to fix the Win32 "problem" with slash vs backslash this weekend by doing the following when reading in the files: my $unixy=join('/',splitdir($File::Find::name)); My idea was to convert all paths to Unix-Style (i.e. slash as directory seperator), so I don't have to use complex regex any time I want to operate on files: m{^/foo/bar$} # better than m{^[/\\:]foo[\//:]bar} Do you know if Perl on Win32 (or other OSes) will convert unixy paths to native paths? I haven't got any Windows machines, so I cannot test it myself... Show quoted text
> And besides, you already have an in_basedir hash value. > Change line 125 to this: > > my @in_basedir=grep { $_->{in_basedir} } @$modules;
Indeed! Thanks for the hint... I've added in_basedir after I wrote the proper_libs check... I'll push a new release later today -- #!/usr/bin/perl http://domm.zsi.at for(ref bless{},just'another'perl'hacker){s-:+-$"-g&&print$_.$/}


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.