Skip Menu |
 

This queue is for tickets about the SVN-Dump CPAN distribution.

Report information
The Basics
Id: 26386
Status: open
Priority: 0/
Queue: SVN-Dump

People
Owner: Nobody in particular
Requestors: dland [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.03
Fixed in: (no value)



Download (untitled) / with headers
text/plain 287b
If all properties are deleted in a record, or there are no properties in the record, the PROPS-END footer will be emitted regardless. The following patch fixes this up (and a few documentation tweaks that I added as I went along trying to figure things out). Nice module! thanks, David
Subject: SD.patch
Download SD.patch
text/x-diff 1.7k
--- SVN-Dump-0.03-edit/lib/SVN/Dump/Property.pm Sun Apr 15 20:49:58 2007 +++ SVN-Dump-0.03/lib/SVN/Dump/Property.pm Tue Nov 21 01:15:21 2006 @@ -46,7 +46,7 @@ for @{ $self->{keys} }; # end marker - $string .= "PROPS-END$NL" if @{ $self->{keys} }; + $string .= "PROPS-END$NL"; return $string; } --- SVN-Dump-0.03-edit/lib/SVN/Dump/Record.pm Sun Apr 15 21:00:30 2007 +++ SVN-Dump-0.03/lib/SVN/Dump/Record.pm Tue Nov 21 01:15:21 2006 @@ -196,8 +196,7 @@ =item delete_property( @k ) -Delete the properties named in C<@p>. Properties -that do not exist in the record will be silently ignored. +Delete the =item set_text( $t ) @@ -321,20 +320,19 @@ =item as_string() -Return a string representation of the record that will be -understood by other Subversion tools, such as C<svnadmin>. +Return a string representation of the record. -B<Warning:> dumping a record currently returns the information that -was read from the original dump. This means that if you modified the -property or text block of a record, the headers will be inconsistent. +B<Warning:> dumping a record currenly gives back the information that +was read from the original dump. Which means that if you modified the +property or text block of a record, the headers will be inconstent. =back =head1 ENCAPSULATION When using C<SVN::Dump> to manipulate a SVN dump, one should not -access the C<SVN::Dump::Headers>, C<SVN::Dump::Property> and -C<SVN::Dump::Text> components of a C<SVN::Dump::Record> object directly, but use +directly access the C<SVN::Dump::Headers>, C<SVN::Dump::Property> and +C<SVN::Dump::Text> components of a C<SVN::Dump::Record> object, but use the appropriate C<set_...()> and C<get_...()> methods of the record object. These methods compute the appropriate modifications of the header values,
Subject: Patch applied?
Download (untitled) / with headers
text/plain 102b
patch seems to think this is already applied to SVN::Dump 0.04. It might be safe to close the ticket.
Subject: Patch was reversed
Download (untitled) / with headers
text/plain 235b
On Sat Apr 03 18:58:44 2010, RCAPUTO wrote: Show quoted text
> patch seems to think this is already applied to SVN::Dump 0.04. It > might be safe to close the ticket.
Actually, the patch sent was reversed. I'll apply it with the doc patches. -- BooK
Subject: Applied the doc patch
Download (untitled) / with headers
text/plain 615b
On Tue Apr 06 08:46:48 2010, BOOK wrote: Show quoted text
> On Sat Apr 03 18:58:44 2010, RCAPUTO wrote:
> > patch seems to think this is already applied to SVN::Dump 0.04. It > > might be safe to close the ticket.
> > Actually, the patch sent was reversed. I'll apply it with the doc patches. >
I only applied the documentation patch. I'm not completely sure about the properties. It's very possible that the current implentation of SVN::Dump behaves incorrectly either with empty properties or deleted properties (Prop-content-length: 0), but I'd prefer to get a bug report that confirms what the expected proper behaviour is.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.