Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id:
26336
Status:
rejected
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
David.Nadler [...] barclaysglobal.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: Do I really need to quote $FindBin::Bin in order to use it?
Date: Fri, 13 Apr 2007 15:47:54 -0700
To: <bug-Perl-Critic@rt.cpan.org>
From: "Nadler, David BGI SF" <David.Nadler@barclaysglobal.com>
Contents of t1.pl: #! perl use strict; use warnings; use version; our $VERSION = qv(0.0.0); use FindBin; my %h = (DIR => $FindBin::Bin); __END__ Contents of t2.pl #! perl use strict; use warnings; use version; our $VERSION = qv(0.0.0); use FindBin; my %h = (DIR => "$FindBin::Bin"); __END__ $ perlcritic -brutal -exclude RCS t1.pl t2.pl t1.pl: Package variable declared or used at line 7, column 17. See pages 73,75 of PBP. (Severity: 3) t2.pl source OK $ perl -v This is perl, v5.6.1 built for sun4-solaris... $ perlcritic -V 1.03 $ uname -a SunOS rdcuxsrv183 5.10 Generic_118833-24 sun4u sparc SUNW,Sun-Fire-V890 Solaris -- This message and any attachments are confidential, proprietary, and may be privileged. If this message was misdirected, Barclays Global Investors (BGI) does not waive any confidentiality or privilege. If you are not the intended recipient, please notify us immediately and destroy the message without disclosing its contents to anyone. Any distribution, use or copying of this e-mail or the information it contains by other than an intended recipient is unauthorized. The views and opinions expressed in this e-mail message are the author's own and may not reflect the views and opinions of BGI, unless the author is authorized by BGI to express such views or opinions on its behalf. All email sent to or from this address is subject to electronic storage and review by BGI. Although BGI operates anti-virus programs, it does not accept responsibility for any damage whatsoever caused by viruses being passed.
My recommendation is to write the code like this: use FindBin qw($Bin); ... my %h = (DIR => $Bin); -- Chris On Fri Apr 13 18:48:42 2007, David.Nadler@barclaysglobal.com wrote:
Show quoted text
> Contents of t1.pl: > #! perl > use strict; > use warnings; > use version; > our $VERSION = qv(0.0.0); > use FindBin; > my %h = (DIR => $FindBin::Bin); > __END__ > > Contents of t2.pl > #! perl > use strict; > use warnings; > use version; > our $VERSION = qv(0.0.0); > use FindBin; > my %h = (DIR => "$FindBin::Bin"); > __END__ > > $ perlcritic -brutal -exclude RCS t1.pl t2.pl > t1.pl: Package variable declared or used at line 7, column 17. See > pages 73,75 of PBP. (Severity: 3) > t2.pl source OK > > $ perl -v > This is perl, v5.6.1 built for sun4-solaris... > > $ perlcritic -V > 1.03 > > $ uname -a > SunOS rdcuxsrv183 5.10 Generic_118833-24 sun4u sparc SUNW,Sun-Fire-V890 > Solaris >


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.