Skip Menu |
 

This queue is for tickets about the Hash-Merge CPAN distribution.

Report information
The Basics
Id: 26076
Status: resolved
Priority: 0/
Queue: Hash-Merge

People
Owner: Nobody in particular
Requestors: dmuey [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Misc Cleanups
Thanks for this excellent module. I have a few recommendations to bring it up to date a bit :) If you're interested I can send a patch that does all of these thingsm just let me know :) 1) remove the shebang 2) remove the comments at the top containing revision info, its in the POD and doesn't match anyway 3) apply some PBP to the code :) 4) Make Clone Optional: a) remove 'use Clone' line b) remove all references to $CLONE_SUPPORT c) change _my_clone() to: sub _my_clone { my ( $arg, $depth ) = @_; if( $clone_behavior ) { require Clone; } if ( !($Clone::VERSION || 0) > 0.09 && !UNIVERSAL::isa( $arg, 'HASH' ) && !UNIVERSAL::isa( $arg, 'ARRAY' )) { my $var = $arg; # Forced clone return $var; } else { if ($depth ) { return Clone::clone( $arg, $depth ); } else { return Clone::clone( $arg ); } } } 5) Exporter/vars stuff doesn't need to be in BEGIN blocks 6) use Exporter ();@ISA = qw(Exporter); could be done as use base 'Exporter'; and is a bit safer.
Download (untitled) / with headers
text/plain 181b
If you are too busy I'd be happy to be comaintainer if you want to make me (DMUEY) comaintainer via pause, just a thought :) I could take care of a few of these rt entries for it
From: DMUEY [...] cpan.org
Download (untitled) / with headers
text/plain 530b
On Tue Apr 03 15:36:13 2007, DMUEY wrote: Show quoted text
> If you are too busy I'd be happy to be comaintainer if you want to > make me (DMUEY) > comaintainer via pause, just a thought :) > > I could take care of a few of these rt entries for it
Thanks for adding me as co maintainer, 0.09 addresses everything here (see Changes file for details) I waited until it was propogated a few days but still is no an option in the "version its resolved in" field so I'll close it and not ehere it 0.09 I'll look over the other reports AIGT/ASAP


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.