Skip Menu |
 

This queue is for tickets about the svk CPAN distribution.

Report information
The Basics
Id: 25761
Status: resolved
Priority: 0/
Queue: svk

People
Owner: Nobody in particular
Requestors: claco [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: v2.0.0_91
Fixed in: (no value)



Subject: Commit message date/time malformed in win32/2.x
Download (untitled) / with headers
text/plain 531b
When committing changes to a local branch and pushing those changes upstream using svk push, the commit message under win32 seems to be missing the time part and spells out the time zone, unlike the commit messages from *nix clients. Here's a sample message from a recent commit to local, pushed up to the mirror/master: r118@np5660: claco | 2007-03-25 Eastern Daylight Time If it weren't for the missing time, it wouldn't be so bad. I would expect something more like: r118@np5660: claco | 2007-02-16 16:29:26 -0500
Download (untitled) / with headers
text/plain 1.6k
On Sun Mar 25 01:56:22 2007, CLACO wrote: Show quoted text
> When committing changes to a local branch and pushing those changes > upstream using svk push, the commit message under win32 seems to be > missing the time part and spells out the time zone, unlike the commit > messages from *nix clients. > > Here's a sample message from a recent commit to local, pushed up to the > mirror/master: > > r118@np5660: claco | 2007-03-25 Eastern Daylight Time > > If it weren't for the missing time, it wouldn't be so bad. I would > expect something more like: > > r118@np5660: claco | 2007-02-16 16:29:26 -0500
Yup. That's almost certainly the issue. IF I svn log the master repo, the first line before the message has the correct date/time: C:\Development\CPAN\Mango>svn log http://svn.handelframework.com/CPAN/Mango/trunk/lib/Mango/Provider/Products.pm ------------------------------------------------------------------------ r1784 | claco | 2007-03-25 01:37:32 -0400 (Sun, 25 Mar 2007) | 3 lines r118@np5660: claco | 2007-03-25 Eastern Daylight Time Added tags() to products provider When I do the same in svk, the first line is wrong: C:\Development\CPAN\Mango>svk log http://svn.handelframework.com/CPAN/Mango/trunk/lib/Mango/Provider/Products.pm ---------------------------------------------------------------------- r119 (orig r1784): claco | 2007-03-25 Eastern Daylight Time r118@np5660: claco | 2007-03-25 Eastern Daylight Time Added tags() to products provider So, I'd summize that during svk push, svk is getting the wrong thing when calling POSIX::strftime...then sending that wrong string along as the new message when committing to the mirror/master.
Download (untitled) / with headers
text/plain 2.2k
On Sun Mar 25 02:10:59 2007, CLACO wrote: Show quoted text
> On Sun Mar 25 01:56:22 2007, CLACO wrote:
> > When committing changes to a local branch and pushing those changes > > upstream using svk push, the commit message under win32 seems to be > > missing the time part and spells out the time zone, unlike the
> commit
> > messages from *nix clients. > > > > Here's a sample message from a recent commit to local, pushed up to
> the
> > mirror/master: > > > > r118@np5660: claco | 2007-03-25 Eastern Daylight Time > > > > If it weren't for the missing time, it wouldn't be so bad. I would > > expect something more like: > > > > r118@np5660: claco | 2007-02-16 16:29:26 -0500
> > > Yup. That's almost certainly the issue. IF I svn log the master repo, > the first line before the message has the correct date/time: > > C:\Development\CPAN\Mango>svn log >
http://svn.handelframework.com/CPAN/Mango/trunk/lib/Mango/Provider/Products.pm Show quoted text
> ------------------------------------------------------------------------ > r1784 | claco | 2007-03-25 01:37:32 -0400 (Sun, 25 Mar 2007) | 3 lines > > r118@np5660: claco | 2007-03-25 Eastern Daylight Time > Added tags() to products provider > > > When I do the same in svk, the first line is wrong: > > C:\Development\CPAN\Mango>svk log >
http://svn.handelframework.com/CPAN/Mango/trunk/lib/Mango/Provider/Products.pm Show quoted text
> ---------------------------------------------------------------------- > r119 (orig r1784): claco | 2007-03-25 Eastern Daylight Time > > r118@np5660: claco | 2007-03-25 Eastern Daylight Time > Added tags() to products provider > > > > So, I'd summize that during svk push, svk is getting the wrong thing > when calling POSIX::strftime...then sending that wrong string along as > the new message when committing to the mirror/master.
Just as a final follow up, changing this code in Util.pm fixes the problem for me on Win32...probably negating the speed increase achieved by the original POSIX usage: sub time2str { my ($format, $time) = @_; #require POSIX; #return POSIX::strftime($format, localtime($time) ); require Date::Format; return Date::Format::strftime($format, [localtime($time)]); } But at least now my commit messages are sane on my laptop. :-)
Subject: Re: [rt.cpan.org #25761] Commit message date/time malformed in win32/2.x
Date: Mon, 26 Mar 2007 17:46:49 +0100
To: bug-svk [...] rt.cpan.org
From: "Chia-Liang Kao" <clkao [...] clkao.org>
Download (untitled) / with headers
text/plain 142b
Hi, Could you try the attached patch which falls back to Date::Format on win32, and adds Date::Format as a dependency on win32. Cheers, CLK

Message body is not shown because sender requested not to inline it.

CC: CLACO [...] cpan.org
Subject: Re: [rt.cpan.org #25761] Commit message date/time malformed in win32/2.x
Date: Mon, 26 Mar 2007 13:02:14 -0400
To: bug-svk [...] rt.cpan.org
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Download (untitled) / with headers
text/plain 473b
clkao@clkao.org via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=25761 > > > Hi, > > Could you try the attached patch which falls back to Date::Format on > win32, and adds Date::Format as a dependency on win32. > > Cheers, > CLK >
Well, sort of. :-) "Can't locate Date::Format in @INC (@INC contains: C:/Program Files/svk/lib .) at SVK/Util.pm line 957" Removed the single quotes from require 'Date::Format'; and it works as expected. -=Chris
Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

fixed in trunk r2360 and will be merged to 2.0-releng. Thanks!


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.