Skip Menu |
 

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CPAN-Reporter CPAN distribution.

Report information
The Basics
Id: 25686
Status: resolved
Priority: 0/
Queue: CPAN-Reporter

People
Owner: Nobody in particular
Requestors: BARBIE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.40
Fixed in: 0.41



Subject: Bogus reports being submited
I assume this relates to all versions of CPAN-Reporter, but have attributed to just the latest version. When a distribution is uploaded to CPAN, unless it is correctly formatted, it should not be tested. If it is, then no report should be sent to the cpan-testers list, as it will only add noise to the list and either not get parsed at all or be badly parsed for both the CPAN Testers website and the CPAN Testers Statistic website. I currently monitor all uploads and report submissions so that authors and testers are alerted when a bogus upload or report appears on the cpan-testers list, thus helping to correct furture uploads and submissions. Two examples are listed below, where the author uploaded just their Perl Module to CPAN. While this is allowed, it should not feature as part of the CPAN Testers framework as there is no supporting information (Makefile/Buildfile/MANIFEST/tests) with which to validate and test it. 427362,upload@pause.perl.org (PAUSE),missing - CPAN Upload: B/BI/BILBO/Template-Perlate-099/Perlate.pm 428032,upload@pause.perl.org (PAUSE),missing - CPAN Upload: J/JQ/JQUINLAN/QVar.pm With CPAN-Reporter this has resulted in the following reports being reported: 428086,david@cantrell.org.uk,unknown - UNKNOWN Perlate.pm i686-linux 2.4.27-3-686 428299,david@cantrell.org.uk,unknown - UNKNOWN Perlate.pm OpenBSD.i386-openbsd 3.5 428312,david@cantrell.org.uk,unknown - UNKNOWN Perlate.pm i686-linux 2.4.27-3-686 428793,david@cantrell.org.uk,unknown - UNKNOWN QVar.pm i686-linux 2.4.27-3-686 428884,david@cantrell.org.uk,unknown - UNKNOWN QVar.pm OpenBSD.i386-openbsd 3.5 If I get time I will look at supplying a patch, but thought it worth reporting this first in the event it is something you would be able to look at sooner. Essentially it boils down to CPAN-Reporter checking that the report it would send is going to be correctly formatted. So the distribution name and version must appear in the subject and the distribution being refered to has a name, version and a valid archive extension (qr/(?:\.(?:tar\.(?:gz|bz2)|tgz|zip))/). If you need any more info give me a shout.
CC: "David Cantrell" <david [...] cantrell.org.uk>, Barbie <barbie [...] missbarbell.co.uk>
Subject: Re: [rt.cpan.org #25686] Bogus reports being submited
Date: Fri, 23 Mar 2007 07:22:52 -0400
To: bug-CPAN-Reporter [...] rt.cpan.org
From: "David Golden" <xdaveg [...] gmail.com>
Download (untitled) / with headers
text/plain 2.8k
On 3/23/07, Barbie via RT <bug-CPAN-Reporter@rt.cpan.org> wrote: Show quoted text
> I assume this relates to all versions of CPAN-Reporter, but have > attributed to just the latest version. > > When a distribution is uploaded to CPAN, unless it is correctly > formatted, it should not be tested. If it is, then no report should be > sent to the cpan-testers list, as it will only add noise to the list and > either not get parsed at all or be badly parsed for both the CPAN > Testers website and the CPAN Testers Statistic website. > > I currently monitor all uploads and report submissions so that authors > and testers are alerted when a bogus upload or report appears on the > cpan-testers list, thus helping to correct furture uploads and submissions. > > Two examples are listed below, where the author uploaded just their Perl > Module to CPAN. While this is allowed, it should not feature as part of > the CPAN Testers framework as there is no supporting information > (Makefile/Buildfile/MANIFEST/tests) with which to validate and test it. > > 427362,upload@pause.perl.org (PAUSE),missing - CPAN Upload: > B/BI/BILBO/Template-Perlate-099/Perlate.pm > 428032,upload@pause.perl.org (PAUSE),missing - CPAN Upload: > J/JQ/JQUINLAN/QVar.pm > > With CPAN-Reporter this has resulted in the following reports being > reported: > > 428086,david@cantrell.org.uk,unknown - UNKNOWN Perlate.pm i686-linux > 2.4.27-3-686 > 428299,david@cantrell.org.uk,unknown - UNKNOWN Perlate.pm > OpenBSD.i386-openbsd 3.5 > 428312,david@cantrell.org.uk,unknown - UNKNOWN Perlate.pm i686-linux > 2.4.27-3-686 > 428793,david@cantrell.org.uk,unknown - UNKNOWN QVar.pm i686-linux > 2.4.27-3-686 > 428884,david@cantrell.org.uk,unknown - UNKNOWN QVar.pm > OpenBSD.i386-openbsd 3.5 > > If I get time I will look at supplying a patch, but thought it worth > reporting this first in the event it is something you would be able to > look at sooner. > > Essentially it boils down to CPAN-Reporter checking that the report it > would send is going to be correctly formatted. So the distribution name > and version must appear in the subject and the distribution being > refered to has a name, version and a valid archive extension > (qr/(?:\.(?:tar\.(?:gz|bz2)|tgz|zip))/). > > If you need any more info give me a shout.
CPAN::Reporter is just glue between CPAN.pm and Test::Reporter, so I'm not sure that CPAN::Reporter is the right place to embed this logic. If you want to validate the subject line, that should happen in Test::Reporter. Perhaps a better fix is with Cantrell's smoke setup -- it shouldn't attempt to test these things that don't look like packages. What is strange is that CPAN.pm shouldn't be running tests unless it has successfully done a "perl Makefile.PL" and "make" (or the Module::Build equivalents). That shouldn't happen for just a .pm file. Perhaps Cantrell is forcing tests -- which might well cause CPAN::Reporter to conclude "UNKNOWN" -- meaning that no tests were found. David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.