Skip Menu |
 

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 24985
Status: resolved
Priority: 0/
Queue: Test-Harness

People
Owner: Nobody in particular
Requestors: cberry [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.64
Fixed in: (no value)



Subject: [PATCH] fix VMS exit handling broken in 2.64
Download (untitled) / with headers
text/plain 208b
2.64 broke the pragma scope necessary for C<use vmsish 'status'> to do its thing. The attached patch fixes that while preserving the encapsulation provided by the set_exit method. strap-analyze.t now passes.
Subject: harness_exit.patch
Download harness_exit.patch
text/x-diff 952b
--- lib/Test/Harness/Results.pm;-0 Sun Feb 11 16:52:17 2007 +++ lib/Test/Harness/Results.pm Thu Feb 15 09:28:58 2007 @@ -118,7 +118,18 @@ sub ok { return $self->{ok} || 0; } -sub set_exit { my $self = shift; $self->{exit} = shift } +sub set_exit { + my $self = shift; + if ($^O eq 'VMS') { + eval { + use vmsish q(status); + $self->{exit} = shift; # must be in same scope as pragma + } + } + else { + $self->{exit} = shift; + } +} sub exit { my $self = shift; return $self->{exit} || 0; --- lib/Test/Harness/Straps.pm;-0 Sun Feb 11 16:52:17 2007 +++ lib/Test/Harness/Straps.pm Thu Feb 15 08:02:55 2007 @@ -296,7 +296,7 @@ sub analyze_file { $results->set_wait($?); if ( $? && $self->{_is_vms} ) { - eval q{use vmsish "status"; $results->set_exit($?); }; + $results->set_exit($?); } else { $results->set_exit( _wait2exit($?) );
Applied in 2.65_02


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.