Skip Menu |
 

This queue is for tickets about the Imager CPAN distribution.

Report information
The Basics
Id: 24859
Status: resolved
Priority: 0/
Queue: Imager

People
Owner: TONYC [...] cpan.org
Requestors: SHLOMIF [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.55
Fixed in: (no value)



Subject: t/t35ttfont.t fails due to "ok" not starting on a newline
Download (untitled) / with headers
text/plain 320b
Attached is a patch to fix a problem where on Mandriva Cooker 2007, with libfreetype6-2.3.1-1plf2007.1 installed, the t/t35ttfont.t fails due to an "ok $I" that is not displayed on a fresh line. Apparently Imager::i_tt_dump_names($hcfont->{id}) may not necessary terminate with a newline. Regards, Shlomi Fish
Subject: Imager-ttf-newline.patch
--- t/t35ttfont.t.orig 2007-02-09 16:33:01.598524382 +0200 +++ t/t35ttfont.t 2007-02-09 16:31:42.626548717 +0200 @@ -147,6 +147,7 @@ print "# ** name table of the test font **\n"; Imager::i_tt_dump_names($hcfont->{id}); + print "\n"; # the test font is known to have a shorter advance width for that char my @bbox = $hcfont->bounding_box(string=>"/", size=>100);
Download (untitled) / with headers
text/plain 780b
On Fri Feb 09 09:38:23 2007, SHLOMIF wrote: Show quoted text
> Attached is a patch to fix a problem where on Mandriva Cooker 2007, > with libfreetype6-2.3.1-1plf2007.1 installed, the t/t35ttfont.t fails > due to an "ok $I" that is not displayed on a fresh line. Apparently > Imager::i_tt_dump_names($hcfont->{id}) may not necessary terminate > with a newline.
Sorry for not replying to this earlier, this ticket didn't seem to come through in email. From looking at the source, i_tt_dump_names() should produce a terminating newline. The only issue I can see is that some of the output might be buffered. I'm setting up a cooker VM to see if I can reproduce and diagnose the problem. Thanks for your report, I expect it to be fixed one way or another for the next release of Imager. Tony
Download (untitled) / with headers
text/plain 566b
On Wed Mar 07 22:12:43 2007, TONYC wrote: Show quoted text
>> From looking at the source, i_tt_dump_names() should produce a
> terminating newline. The only issue I can see is that some of the > output might be buffered. > > I'm setting up a cooker VM to see if I can reproduce and diagnose the > problem.
I wasn't able to reproduce this problem in a Mandriva Cooker VM. I've added a fflush() to the end of i_tt_dump_names() which should prevent buffering from causing a problem. If you continue to see this problem in future releases of Imager, please let me know. Thanks Tony
This problem should be fixed in Imager 0.56, released yesterday. Thanks for your report. Tony


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.