Skip Menu |
 

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 2479
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 0.01
  • 2.0
  • 2.1
  • 2.2
  • 2.4
  • 2.7
  • 2.9
  • 2.91
  • 2.92
  • 2.94
  • 3.1
  • 3.2
  • 3.2.2.1
  • 3.3
  • 3.4
  • 3.5
  • 3.6
  • 3.7
  • 3.8
  • 3.9
  • 3.10
  • 3.11
  • 3.91
  • 3.92
  • 3.93
Fixed in: (no value)



Subject: sub flush returns true even on failure (very much not good)
Download (untitled) / with headers
text/plain 946b
sub flush returns true even on failure (very much not good) I was playing with driver:File and doing $session->flush() or die $session->error(); when the driver couldn't save RESULTED IN NO ERRORS!!!!!!!!!! I CANNOT BELIEVE MY EYES!!!!!!!!!! I CANNOT CONCIEVE OF NOBODY RUNNING INTO THIS BEFORE VERSION 3.93 THIS IS SO CRITICAL IT'S INSANE Kindly fix it immediately, please. sub flush { my $self = shift; my $status = $self->{_STATUS}; if ( $status == MODIFIED ) { return undef unless $self->store($self->id, $self->{_OPTIONS}, $self->{_DATA}); $self->{_STATUS} = SYNCED; return 1; }elsif ( $status == DELETED ) { return $self->remove($self->id, $self->{_OPTIONS}); } } btw, this is how DESTROY should look sub DESTROY { my $self = shift; $self->flush() or die "EEEEEK! COULD NOT FLUSH() ",$self->error(); $self->can('teardown') && $self->teardown(); }
Subject: sub flush returns true even on failure (very much not good) (fixed)
Download (untitled) / with headers
text/plain 276b
Sorry about that. Fixed in 3.94. Thanks for the notice. I have just uploaded it to CPAN, and should be avaialble for download in few hours. Untill then you can also download it from http://www.handalak.com/tmp/CGI-Session-3.94.tar.gz. Sherzod Ruzmetov <sherzodr@cpan.org>


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.