Skip Menu |
 

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 24661
Status: resolved
Priority: 0/
Queue: Module-Build

People
Owner: Nobody in particular
Requestors: kwilliams [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.2806
Fixed in: (no value)

Attachments


Subject: --extra_compiler_flags doesn't split properly
Download (untitled) / with headers
text/plain 235b
Running perl Build.PL --extra_compiler_flags '-I/Users/u0048513/Downloads/svm_light -Wall' results in the compiler looking for a directory called "/Users/u0048513/Downloads/svm_light - Wall". This needs to be split properly. -Ken
Download (untitled) / with headers
text/plain 127b
Isn't this just another manifestation of "option and argument processing"? http://rt.cpan.org/Ticket/Display.html?id=8435
Download (untitled) / with headers
text/plain 391b
On Mon Jan 29 12:54:34 2007, KWILLIAMS wrote: Show quoted text
> Running perl Build.PL --extra_compiler_flags > '-I/Users/u0048513/Downloads/svm_light -Wall' > > results in the compiler looking for a directory called > "/Users/u0048513/Downloads/svm_light -Wall". > > This needs to be split properly.
Ken, This appears to be fixed now. Does it need a test or can we close this ticket? Thanks, Eric
Download (untitled) / with headers
text/plain 322b
On Tue Jan 13 02:00:53 2009, EWILHELM wrote: Show quoted text
> This appears to be fixed now. Does it need a test or can we close this > ticket?
I thought I had commit access, but apparently not. Anyway, here is a patch to explicitly test the case reported in this bug report. The test passes, so the bug is indeed fixed. Best, David
Index: t/basic.t =================================================================== --- t/basic.t (revision 12873) +++ t/basic.t (working copy) @@ -195,12 +195,12 @@ is_deeply $mb->extra_linker_flags, ['-L/foo', '-L/bar'], "Should split shell string into list"; # Try again with command-line args - eval {Module::Build->run_perl_script('Build.PL', [], ['--extra_compiler_flags', '-I/foo -I/bar', - '--extra_linker_flags', '-L/foo -L/bar'])}; + eval {Module::Build->run_perl_script('Build.PL', [], ['--extra_compiler_flags', '-I/foo -Wall', + '--extra_linker_flags', '-L/foo -Wall'])}; $mb = Module::Build->resume; ok $mb; - is_deeply $mb->extra_compiler_flags, ['-I/foo', '-I/bar'], "Should split shell string into list"; - is_deeply $mb->extra_linker_flags, ['-L/foo', '-L/bar'], "Should split shell string into list"; + is_deeply $mb->extra_compiler_flags, ['-I/foo', '-Wall'], "Should split shell string into list"; + is_deeply $mb->extra_linker_flags, ['-L/foo', '-Wall'], "Should split shell string into list"; }
Download (untitled) / with headers
text/plain 145b
Thanks. Given that the test was really already there and this just changes it cosmetically, I'll just mark it as fixed without patching. -Ken


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.