Skip Menu |
 

This queue is for tickets about the grepmail CPAN distribution.

Report information
The Basics
Id: 24341
Status: resolved
Worked: 20 min
Priority: 0/
Queue: grepmail

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)

Attachments


Subject: Test suite failures with Mail::Mbox::MessageParser 1.5000
Date: Fri, 12 Jan 2007 14:32:08 +0000
To: bug-grepmail [...] rt.cpan.org
From: Paul Howarth <paul [...] city-fan.org>
Download (untitled) / with headers
text/plain 322b
After upgrading Mail::Mbox::MessageParser to 1.5000, the grepmail test suite fails in multiple places. Regressing Mail::Mbox::MessageParser back to 1.4005 results in the test suite passing. The attached build log is for Fedora Core 4 x86_64 but I observed exactly the same problem with Red Hat 9 i386. Regards, Paul.

Message body is not shown because it is too large.

Download (untitled) / with headers
text/plain 786b
On Fri Jan 12 09:32:49 2007, paul@city-fan.org wrote: Show quoted text
> After upgrading Mail::Mbox::MessageParser to 1.5000, the grepmail test > suite fails in multiple places. Regressing Mail::Mbox::MessageParser > back to 1.4005 results in the test suite passing. The attached build log > is for Fedora Core 4 x86_64 but I observed exactly the same problem with > Red Hat 9 i386. > > Regards, Paul.
Hello, this patch should fix your problem. --- a/grepmail +++ b/grepmail @@ -1153,7 +1153,7 @@ sub Process_Mail_File # This is the main loop. It's executed once for each email # Direct access for performance reasons #while($folder_reader->end_of_file()) - while(!$folder_reader->{'end_of_file'}) + while(!$folder_reader->end_of_file) { dprint "Reading email" if $opts{'D'};
Subject: Re: [rt.cpan.org #24341] Test suite failures with Mail::Mbox::MessageParser 1.5000
Date: Tue, 27 Feb 2007 18:06:40 +0000
To: bug-grepmail [...] rt.cpan.org
From: Paul Howarth <paul [...] city-fan.org>
Download (untitled) / with headers
text/plain 965b
Alexey Tourbin via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=24341 > > > On Fri Jan 12 09:32:49 2007, paul@city-fan.org wrote:
>> After upgrading Mail::Mbox::MessageParser to 1.5000, the grepmail test >> suite fails in multiple places. Regressing Mail::Mbox::MessageParser >> back to 1.4005 results in the test suite passing. The attached build log >> is for Fedora Core 4 x86_64 but I observed exactly the same problem with >> Red Hat 9 i386. >> >> Regards, Paul.
> > Hello, > > this patch should fix your problem. > > --- a/grepmail > +++ b/grepmail > @@ -1153,7 +1153,7 @@ sub Process_Mail_File > # This is the main loop. It's executed once for each email > # Direct access for performance reasons > #while($folder_reader->end_of_file()) > - while(!$folder_reader->{'end_of_file'}) > + while(!$folder_reader->end_of_file) > { > dprint "Reading email" if $opts{'D'}; >
Thanks; that works very nicely! Cheers, Paul.
From: david [...] coppit.org
Download (untitled) / with headers
text/plain 696b
On Tue Feb 27 11:04:16 2007, ATOURBIN wrote: Show quoted text
> this patch should fix your problem. > > --- a/grepmail > +++ b/grepmail > @@ -1153,7 +1153,7 @@ sub Process_Mail_File > # This is the main loop. It's executed once for each email > # Direct access for performance reasons > #while($folder_reader->end_of_file()) > - while(!$folder_reader->{'end_of_file'}) > + while(!$folder_reader->end_of_file) > { > dprint "Reading email" if $opts{'D'};
Gah! Two lessons for me: (1) ALWAYS retest grepmail when I update M:M:MessageParser, (2) NEVER use an internal interface, even for performance. I'll be releasing 5.3034 with this fix. Thanks to both of you for the report and patch. David


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.