Skip Menu |
 

This queue is for tickets about the Acme-MetaSyntactic-RefactorCode CPAN distribution.

Report information
The Basics
Id: 23700
Status: resolved
Priority: 0/
Queue: Acme-MetaSyntactic-RefactorCode

People
Owner: JFENAL [...] cpan.org
Requestors: a.r.ferreira [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] AM::RefactorCode broke after B::Deobfuscate 0.14+
Date: Wed, 29 Nov 2006 14:31:40 -0200
To: bug-acme-metasyntactic-refactorcode [...] rt.cpan.org, "Jérôme Fenal" <jfenal [...] free.fr>
From: "Adriano Ferreira" <a.r.ferreira [...] gmail.com>
Download (untitled) / with headers
text/plain 1.3k
Hello, Jérôme. When I tried to use Acme::MetaSyntactic::RefactorCode according to the synopsis, I always ended up with the same refactoring (no matter the theme). Digging away the problem, I found that the trick to override *B::Deobfusctate::DATA stopped working after version 0.14. See the bug report here: http://rt.cpan.org/Public/Bug/Display.html?id=23697 Then I tried to write something to make AMR to work again. The attached patch is the outcome of this effort. The broken API of B::Deobfuscate has not been improved. Instead of stuffing the names in the DATA handle, now we are supposed to stuff it into a module B::Deobfuscate::Dict::whatever. Then I wrote B::Deobfuscate::Dict::RefactorCode. The patch raises the requirement of B::Deobfuscate to 0.14 or later. Also the module no longer inherits from B::Deobfuscate -- it just uses it. I will try to contact Joshua ben Jore with some improvements to the B::Deobfuscate API. I hope that soon we may have a much more concise way to introduce a customized dictionary to B::Deobfuscate. But by now, I would really appreciate if you consider this patch. --- Other minor details: (1) removed "use Data::Dumper;" which is not used (2) fixed the RT address bug-acme-metasyntactic-refacecode@rt.cpan.org to bug-acme-metasyntactic-refactorcode@rt.cpan.org --- Best regards, Adriano Ferreira.
Download refactor.diff
text/x-diff 4.3k

Message body is not shown because sender requested not to inline it.

From: JFENAL [...] cpan.org
Download (untitled) / with headers
text/plain 318b
Le Mer. Nov. 29 11:33:02 2006, a.r.ferreira@gmail.com a écrit : Show quoted text
> Hello, Jérôme. >
Hi Adriano, thanks for the patches and the feedback. 0.03 has been released as you saw. And 0.04 should solve remaining issues. J. -- Jérôme Fenal - jfenal at gmail dot com http://fenal.org/ - http://search.cpan.org/~jfenal/
Download (untitled) / with headers
text/plain 109b
0.03 released. -- Jérôme Fenal - jfenal at free dot fr http://fenal.org/ - http://search.cpan.org/~jfenal/


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.