|Subject:||[PATCH] AM::RefactorCode broke after B::Deobfuscate 0.14+|
|Date:||Wed, 29 Nov 2006 14:31:40 -0200|
|To:||bug-acme-metasyntactic-refactorcode [...] rt.cpan.org, "Jérôme Fenal" <jfenal [...] free.fr>|
|From:||"Adriano Ferreira" <a.r.ferreira [...] gmail.com>|
Hello, Jérôme. When I tried to use Acme::MetaSyntactic::RefactorCode according to the synopsis, I always ended up with the same refactoring (no matter the theme). Digging away the problem, I found that the trick to override *B::Deobfusctate::DATA stopped working after version 0.14. See the bug report here:Then I tried to write something to make AMR to work again. The attached patch is the outcome of this effort. The broken API of B::Deobfuscate has not been improved. Instead of stuffing the names in the DATA handle, now we are supposed to stuff it into a module B::Deobfuscate::Dict::whatever. Then I wrote B::Deobfuscate::Dict::RefactorCode. The patch raises the requirement of B::Deobfuscate to 0.14 or later. Also the module no longer inherits from B::Deobfuscate -- it just uses it. I will try to contact Joshua ben Jore with some improvements to the B::Deobfuscate API. I hope that soon we may have a much more concise way to introduce a customized dictionary to B::Deobfuscate. But by now, I would really appreciate if you consider this patch. --- Other minor details: (1) removed "use Data::Dumper;" which is not used (2) fixed the RT address firstname.lastname@example.org to email@example.com --- Best regards, Adriano Ferreira.
Message body is not shown because sender requested not to inline it.