This queue is for tickets about the Module-Dependency CPAN distribution.

Report information
The Basics
Id:
22955
Status:
open
Priority:
Low/Low

People
Owner:
Nobody in particular
Requestors:
david.r.throop [...] boeing.com
Cc:
AdminCc:

BugTracker
Severity:
(no value)
Broken in:
(no value)
Fixed in:
(no value)



Subject: Bugs in the Module::Dependency::Grapher - missing files, failed test
Date: Fri, 10 Nov 2006 14:19:37 -0600
To: <bug-Module-Dependency@rt.cpan.org>
From: "Throop, David R" <david.r.throop@boeing.com>
Show quoted text
> I noticed some bugs in Dependency::Grapher. I'm installing from > module-dependency-1.86.tar. I'm running under Solaris. > > * Some of the README files are missing. The > Module-Dependency-1.86/README references README.EXAMPLES > README.COMMANDS README.MODULES. But README and README.EXAMPLES are > the only ones in the distribution. (I append the tar listing at the > end of this message.) > * I'm also getting errors when I test the make. I've appended > that below the tar listing. Any ideas on this? > > I'd really appreciate it if you can help me get a complete > distribution. > > David R Throop > 281 226 6818 - Boeing Twr II desk > 281 483 5396 - NASA bldg 32 > 281 460 8415 - cell phone > > ====================================================================== > ============= > > > > pat% tar -tf module-dependency-1.86.tar > Module-Dependency-1.86/ > Module-Dependency-1.86/CHANGES > Module-Dependency-1.86/examples/ > Module-Dependency-1.86/examples/example.css > Module-Dependency-1.86/examples/example.eps > Module-Dependency-1.86/examples/example.html > Module-Dependency-1.86/examples/example.ps > Module-Dependency-1.86/examples/example.txt > Module-Dependency-1.86/examples/example1.gif > Module-Dependency-1.86/examples/example1.svg > Module-Dependency-1.86/examples/example2.gif > Module-Dependency-1.86/examples/example2.svg > Module-Dependency-1.86/examples/example3.gif > Module-Dependency-1.86/examples/example3.svg > Module-Dependency-1.86/examples/example4.gif > Module-Dependency-1.86/examples/example5.gif > Module-Dependency-1.86/examples/pmd_cgidepend.plx > Module-Dependency-1.86/examples/pmd_cgiform.html > Module-Dependency-1.86/examples/README.EXAMPLES > Module-Dependency-1.86/INSTALL > Module-Dependency-1.86/lib/ > Module-Dependency-1.86/lib/Module/ > Module-Dependency-1.86/lib/Module/Dependency/ > Module-Dependency-1.86/lib/Module/Dependency/Grapher.pm > Module-Dependency-1.86/lib/Module/Dependency/Indexer.pm > Module-Dependency-1.86/lib/Module/Dependency/Info.pm > Module-Dependency-1.86/lib/Module/Dependency.pod > Module-Dependency-1.86/LICENSE > Module-Dependency-1.86/Makefile.PL > Module-Dependency-1.86/MANIFEST > Module-Dependency-1.86/META.yml > Module-Dependency-1.86/pmd_dump.pl > Module-Dependency-1.86/pmd_grapher.plx > Module-Dependency-1.86/pmd_indexer.plx > Module-Dependency-1.86/README > Module-Dependency-1.86/t/ > Module-Dependency-1.86/t/00base.t > Module-Dependency-1.86/t/01info.t > Module-Dependency-1.86/t/02indexer.t > Module-Dependency-1.86/t/03indexing.t > Module-Dependency-1.86/t/04grapher.t > Module-Dependency-1.86/t/99cleanup.t > Module-Dependency-1.86/t/dbdump.dd > Module-Dependency-1.86/t/u/ > Module-Dependency-1.86/t/u/a.pm > Module-Dependency-1.86/t/u/b.pm > Module-Dependency-1.86/t/u/c.pm > Module-Dependency-1.86/t/u/d.pm > Module-Dependency-1.86/t/u/e.pm > Module-Dependency-1.86/t/u/f.pm > Module-Dependency-1.86/t/u/g.pm > Module-Dependency-1.86/t/u/h.pm > Module-Dependency-1.86/t/u/x.pl > Module-Dependency-1.86/t/u/y.pl > Module-Dependency-1.86/t/u/z.cgi > > ====================================================================== > ====== > > pat% perl Makefile.PL PREFIX=~/perl/lib LIB=~/perl/lib > Writing Makefile for Module::Dependency > > pat% make > cp pmd_indexer.plx blib/script/pmd_indexer.plx > /usr/perl5/5.8.8/bin/perl "-MExtUtils::MY" -e "MY->fixin(shift)" > blib/script/pmd_indexer.plx > cp pmd_grapher.plx blib/script/pmd_grapher.plx > /usr/perl5/5.8.8/bin/perl "-MExtUtils::MY" -e "MY->fixin(shift)" > blib/script/pmd_grapher.plx > cp pmd_dump.pl blib/script/pmd_dump.pl > /usr/perl5/5.8.8/bin/perl "-MExtUtils::MY" -e "MY->fixin(shift)" > blib/script/pmd_dump.pl > Manifying blib/man1/pmd_indexer.plx.1 > Manifying blib/man1/pmd_grapher.plx.1 > Manifying blib/man1/pmd_dump.pl.1 > Manifying blib/man3/Module::Dependency::Info.3 > Manifying blib/man3/Module::Dependency::Grapher.3 > Manifying blib/man3/Module::pmd_dump.3 > Manifying blib/man3/Module::Dependency::Indexer.3 > Manifying blib/man3/Module::Dependency.3 > > pat% make test > PERL_DL_NONLAZY=1 /usr/perl5/5.8.8/bin/perl "-MExtUtils::Command::MM" > "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/00base........ok > t/01info........ok > t/02indexer.....ok > t/03indexing....ok > t/04grapher.....ok 1/17skipping GD tests at t/04grapher.t line 58. > Use of uninitialized value in length at > lib/Module/Dependency/Grapher.pm line 493. > Use of uninitialized value in length at > lib/Module/Dependency/Grapher.pm line 493. > Use of uninitialized value in length at > lib/Module/Dependency/Grapher.pm line 493. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > > # Failed test in t/04grapher.t at line 81. > t/04grapher.....NOK 13 > # Failed test in t/04grapher.t at line 83. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > Use of uninitialized value in concatenation (.) or string at > lib/Module/Dependency/Grapher.pm line 517. > # Looks like you failed 2 tests of 17. > t/04grapher.....dubious > Test returned status 2 (wstat 512, 0x200) > DIED. FAILED tests 13, 15 > Failed 2/17 tests, 88.24% okay (less 5 skipped tests: 10 okay, > 58.82%) > t/99cleanup.....ok > Failed Test Stat Wstat Total Fail Failed List of Failed > ---------------------------------------------------------------------- > --------- > t/04grapher.t 2 512 17 2 11.76% 13 15 > 5 subtests skipped. > Failed 1/6 test scripts, 83.33% okay. 2/92 subtests failed, 97.83% > okay. > *** Error code 29 > make: Fatal error: Command failed for target `test_dynamic' > >
The 'missing' readme files are no longer present, the contents was merged into other files. Module::Dependency::Grapher is in need of some love. I've never used it myself since I took over the distribution, so it's probably fallen out of date with changes in the data. If you send me your auth.perl.org userid I'be be very happy to give you write access to the repository so you can contribute to the evolution of the module.
Subject: RE: [rt.cpan.org #22955] Bugs in the Module::Dependency::Grapher - missing files, failed test
Date: Mon, 13 Nov 2006 11:01:06 -0600
To: <bug-Module-Dependency@rt.cpan.org>
From: "Throop, David R" <david.r.throop@boeing.com>
Tim, Thanks for the update. I've asked my boss for permission to post my bugfixes back to CPAN. (I don't have an auth.perl.org userid yet.) Your response - that there have been changes in the data since the Grapher module was last maintained - helps me understand what I'm seeing here. In particular, the code expects that Module::Dependency::Info::getItem will return an $obj with a 'package' and a 'filename' attribute. This is (no longer?) true for objects representing * pragmas * modules that are 'use'd in the code but not part of the file-list given to the Module::Dependency::Index. * scripts that have no 'package' declaration. However, each of these obj seem to have a 'key' attribute with the same kind of info in them. I *think* I can just change the $obj->{package} and $obj->{filename} to $obj->{key} and it will run as ought. Does that comport with what changes you've seen to the data structure? Is there any quick way to suppress the pragma's from the list? Thanks David Throop
Show quoted text
-----Original Message----- From: Tim_Bunce via RT [mailto:bug-Module-Dependency@rt.cpan.org] Sent: Friday, November 10, 2006 5:40 PM To: Throop, David R Subject: [rt.cpan.org #22955] Bugs in the Module::Dependency::Grapher - missing files, failed test <URL: http://rt.cpan.org/Ticket/Display.html?id=22955 > The 'missing' readme files are no longer present, the contents was merged into other files. Module::Dependency::Grapher is in need of some love. I've never used it myself since I took over the distribution, so it's probably fallen out of date with changes in the data. If you send me your auth.perl.org userid I'be be very happy to give you write access to the repository so you can contribute to the evolution of the module.
On Mon Nov 13 12:02:42 2006, david.r.throop@boeing.com wrote:
Show quoted text
> Tim, > > Thanks for the update. I've asked my boss for permission to post my > bugfixes back to CPAN. (I don't have an auth.perl.org userid yet.)
Great.
Show quoted text
> Your response - that there have been changes in the data since the > Grapher module was last maintained - helps me understand what I'm seeing > here. > > In particular, the code expects that Module::Dependency::Info::getItem > will return an $obj with a 'package' and a 'filename' attribute. This > is (no longer?) true for objects representing > * pragmas
yes
Show quoted text
> * modules that are 'use'd in the code but not part of the file-list > given to the Module::Dependency::Index.
yes (essentially the same situation as pragmas)
Show quoted text
> * scripts that have no 'package' declaration.
Those should have a 'filename' attribute (from memory) but won't have a 'package' attribute.
Show quoted text
> However, each of these obj seem to have a 'key' attribute with the same > kind of info in them. I *think* I can just change the $obj->{package} > and $obj->{filename} to $obj->{key} and it will run as ought. Does that > comport with what changes you've seen to the data structure?
As I recall (it's been a while) Module::Dependency::Index now creates nodes for modules that are referenced but not actually parsed (ie the first two cases above). So it would be reasonable to filter those out rather than trying to accomodate them. Another change that may be relevant is that the paths are now relative instead of absolute. There are also a few extra attributes, including the absolute path that's the base for the relative path.
Show quoted text
> Is there any quick way to suppress the pragma's from the list?
I'd probably just use grep { ... } I hope all that helps. Tim.


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.