Skip Menu |
 

This queue is for tickets about the DBIx-Class-Schema-Loader CPAN distribution.

Report information
The Basics
Id: 22425
Status: resolved
Priority: 0/
Queue: DBIx-Class-Schema-Loader

People
Owner: blblack [...] gmail.com
Requestors: alexchorny [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.03008
Fixed in: 0.03009



Subject: test failure
Download (untitled) / with headers
text/plain 192b
ActiveState perl v5.8.7 built for MSWin32-x86-multi-thread Binary build 813 DBIx::Class 0.07002 SQL::Abstract::Limit 0.12 See attached test log. ------- Alexandr Ciornii, http://chorny.net
Subject: error.log
Download error.log
application/octet-stream 5k

Message body not shown because it is not plain text.

Download (untitled) / with headers
text/plain 455b
On Sun Oct 22 13:44:20 2006, alexchorny@gmail.com wrote: Show quoted text
> ActiveState perl v5.8.7 built for MSWin32-x86-multi-thread > Binary build 813 > > DBIx::Class 0.07002 > SQL::Abstract::Limit 0.12 > > See attached test log. >
Can you please make an effort to determine what the actual cause is? I don't use any Win32-like platforms, and various *nix-like platforms are reporting good on make test, so I suspect its a Win32-ism that needs to be worked around.
From: Alexandr Ciornii <alexchorny [...] gmail.com>
Download (untitled) / with headers
text/plain 697b
Error is in $abs_dump_dir = Cwd::abs_path($self->dump_directory) if $self->dump_directory; line from DBIx::Class::Schema::Loader::Base. Cwd::abs_path == Cwd::fast_abs_path on MSWin32. It checks that directory exists. _perl_abs_path which is used on *nix has special case if directory does not exists. Patch: replace this line with use File::Spec; $abs_dump_dir = (\&Cwd::abs_path eq \&Cwd::fast_abs_path ? File::Spec->rel2abs($self->dump_directory) : Cwd::abs_path($self->dump_directory)) if $self->dump_directory; Tests pass with this line. Tested on Windows and Linux. P.S. _ensure_dump_subdirs should use File::Spec. ------- Alexandr Ciornii, http://chorny.net
Fixed in 0.03009 I'm pretty sure. Reopen if I didn't get it right :)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.