This queue is for tickets about the CPAN CPAN distribution.

Report information
The Basics
Id:
22069
Status:
resolved
Priority:
Low/Low
Queue:

People
Owner:
Nobody in particular
Requestors:
mschwern [...] cpan.org
Cc:
AdminCc:

BugTracker
Severity:
Unimportant
Broken in:
1.8801
Fixed in:
(no value)



Subject: Change default colorize_print to just "bold"
I found the default coloring of "bold blue on_white" for CPAN shell output to be a bit garish. Straight bold works well to highlight normal shell output without screaming it. The blue is a bit much, especially on a black background. It will also match well whatever color scheme the user is using. So I propose the default for colorize_print be changed to just "bold".
Sorry, I left the default with blue/red to increase the probability that a new user really sees the effect. They can always change the value later but the initial default must have maximal visibility. Thanks nonetheless, it provided interesting arguing with myself:)
FWIW I don't agree that normal CPAN shell output should be so prominent. It should be distinct from build output, but does not have the same visual priority as a warning. Could you remove the "on_white" then from both colorize_print and colorize_warn? It looks horrid against a non-white background and against white it isn't doing anything. Bold blue and red should stand out plenty against a sane background.
Subject: Re: [rt.cpan.org #22069] Change default colorize_print to just "bold"
Date: Thu, 04 Jan 2007 07:13:23 +0100
To: bug-CPAN@rt.cpan.org
From: andreas.koenig.7os6VVqR@franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Wed, 03 Jan 2007 19:35:50 -0500, "Michael_G_Schwern via RT" <bug-CPAN@rt.cpan.org> said:
Show quoted text
> Queue: CPAN > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=22069 >
Show quoted text
> FWIW I don't agree that normal CPAN shell output should be so prominent. > It should be distinct from build output, but does not have the same > visual priority as a warning.
We are in violent agreement. This is why I made it configurable.
Show quoted text
> Could you remove the "on_white" then from both colorize_print and > colorize_warn?
So that we really fuck up terminals that have a blue background?
Show quoted text
> It looks horrid against a non-white background
This seems to be your main point. But on any default background you will find combinations that look horrid, so we cannot always win here.
Show quoted text
> and against white it isn't doing anything.
Not true on my xterm. My xterm uses a different white for the default background than for the on_white background. But what is more important is that "blue on_white" does an infinitely better job on a terminal that has a blue background. Because if the background is blue and the foreground color is blue and the on_white is missing, then the user will not see any further output from the shell.
Show quoted text
> Bold blue and red should stand out plenty against a sane > background.
This is why it is configurable. The only thing I could come up with quickly is to write a small colordemo and inject it before I ask the questions. if ($CPAN::META->has_inst("Term::ANSIColor")) { my $T="gYw"; print " on_ on_y ". " on_ma on_\n"; print " on_black on_red green ellow ". "on_blue genta on_cyan white\n"; for my $FG ("","bold","black","bold black","red","bold red","green", "bold green","yellow","bold yellow","blue","bold blue", "magenta","bold magenta", "cyan","bold cyan","white","bold white"){ printf "%12s ", $FG; for my $BG ("",map {"on_$_"} qw(black red green yellow blue magenta cyan white)){ print $FG||$BG ? Term::ANSIColor::colored(" $T ","$FG $BG") : " $T "; } print "\n"; } print "\n"; } Yes, this seems helpful to me, it's in. -- andreas
Fixed in 1.88_xx for some while now, 1.88_79 is current release candidate. Closing open bugs now to clarify their status. Closing this one. Thanks


This service runs on Request Tracker, is sponsored by The Perl Foundation, and maintained by Best Practical Solutions.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.