Skip Menu |
 

This queue is for tickets about the RT-Integration-SVN CPAN distribution.

Report information
The Basics
Id: 21905
Status: open
Priority: 0/
Queue: RT-Integration-SVN

People
Owner: Nobody in particular
Requestors: CDENT [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.04
Fixed in: (no value)



Subject: Multiple RT reports when using svk smerge -l
Download (untitled) / with headers
text/plain 509b
This is not so much a bug as a feature request or consideration. The current PullUpdate.html looks for ^\s*RT- to trigger changes in the RT database. When doing smart merges with svk sm -sl, old logs, which have already triggered something in the RT database do the same trigger again. One way around this would be to match on ^RT- as the smart merge indents the commit messages it gathers. We can implement this for ourselves, but thought it might be useful elsewhere, so the simple patch is attached.
Subject: svk.smerge-l.diff
--- PullUpdate.html.orig 2006-10-04 17:39:46.000000000 -0700 +++ PullUpdate.html 2006-10-04 17:40:48.000000000 -0700 @@ -51,21 +51,21 @@ my $update_owner = ''; my %set; foreach my $line (@msg) { - if ( $line =~ /^\s*RT-Ticket:\s*(\w*?)(?:\#?)(\d*)/i ) { + if ( $line =~ /^RT-Ticket:\s*(\w*?)(?:\#?)(\d*)/i ) { next if ($1 && $1 !~ /^$RT::rtname$/i); $ticket = RT::Ticket->new($user); $ticket->Load($2); } - elsif ( $line =~ /^\s*RT-Status:\s*(\w+)/i ) { + elsif ( $line =~ /^RT-Status:\s*(\w+)/i ) { $update_status = lc($1); } - elsif ( $line =~ /^\s*RT-(?:Update|Action):\s*(comment|correspond)/i ) { + elsif ( $line =~ /^RT-(?:Update|Action):\s*(comment|correspond)/i ) { $update_type = lc($1); } - elsif ( $line =~ /^\s*RT-Owner:\s*(\w+)/i ) { + elsif ( $line =~ /^RT-Owner:\s*(\w+)/i ) { $update_owner = $1; } - elsif ( $line =~ /^\s*RT-(\w+):\s*(\w+)/i ) { + elsif ( $line =~ /^RT-(\w+):\s*(\w+)/i ) { $set{$1} = $2; } else {
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #21905] Multiple RT reports when using svk smerge -l
Date: Thu, 5 Oct 2006 14:22:47 -0400
To: via RT <bug-RT-Integration-SVN [...] rt.cpan.org>
From: jesse <jesse [...] fsck.com>
Download (untitled) / with headers
text/plain 623b
Show quoted text
> > The current PullUpdate.html looks for ^\s*RT- to trigger changes in the RT database. > > When doing smart merges with svk sm -sl, old logs, which have already triggered something in > the RT database do the same trigger again. > > One way around this would be to match on ^RT- as the smart merge indents the commit > messages it gathers.
So, on the other side, we find it useful to keep track of which branches things get merged between. I'd be amenable to something clever, though. -j Show quoted text
> We can implement this for ourselves, but thought it might be useful elsewhere, so the simple > patch is attached.
--


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

Please report any issues with rt.cpan.org to rt-cpan-admin@bestpractical.com.